Skip to content

[release-4.18] CNTRLPLANE-1610: Backport StreamingCollectionEncoding for JSON and protobuf #2483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: release-4.18
Choose a base branch
from
Open

[release-4.18] CNTRLPLANE-1610: Backport StreamingCollectionEncoding for JSON and protobuf #2483

wants to merge 8 commits into from
+2,368 −34

Conversation

rh-roman
Copy link

@rh-roman rh-roman commented Oct 1, 2025 •
edited
Loading

Due to significant customer need for performance improvements related to API server pressure from large LIST requests, backporting the API streaming features that have been introduced in 1.33/1.34 related to kubernetes/enhancements#3157

Metrics 4.18 vs 4.18 with StreamingCollectionEncoding enabled doc.

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Oct 1, 2025
@openshift-ci-robot
Copy link

@rh-roman: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from deads2k and jerpeter1 October 1, 2025 23:37
@openshift-ci openshift-ci bot added vendor-update Touching vendor dir or related files needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 1, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 1, 2025

Hi @rh-roman. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@benluddy
Copy link

benluddy commented Oct 2, 2025

/retitle [release-4.18] Backport StreamingCollectionEncoding for JSON and protobuf

@openshift-ci openshift-ci bot changed the title Backport StreamingCollectionEncoding for JSON and protobuf (4.18) [release-4.18] Backport StreamingCollectionEncoding for JSON and protobuf Oct 2, 2025
nkeert and others added 3 commits October 8, 2025 13:39
@nkeert @rh-roman
UPSTREAM: 130190: Add a test to validate deferredResponseWriteron mul…
d7c6a6a 
…tiple write calls

Signed-off-by: nkeert <[email protected]>
@z1cheng @rh-roman
UPSTREAM: 130281: Implement chunking for gzip encoder in deferredResp…
c515586 
…onseWriter

Signed-off-by: z1cheng <[email protected]>
@serathius @rh-roman
UPSTREAM: 130220: Add tests for encoding collections in JSON for KEP-…
64d5177 
…5116

Used test cases from:
* Original PR kubernetes#129334
* KEP https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/5116-streaming-response-encoding#unit-tests

For now testing current serializer implementation to show encoder
behavior and agree on set of tests. Having a separate PR should make review easier.
In separate PR will add the implementation for streaming that should
provide same response byte-to-byte.
@rh-roman rh-roman force-pushed the backport-api-stream-418 branch from b7b7574 to 711c464 Compare October 8, 2025 20:45
@openshift-ci-robot
Copy link

@rh-roman: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@rh-roman rh-roman changed the title [release-4.18] Backport StreamingCollectionEncoding for JSON and protobuf [release-4.18] OCPSTRAT-2467: Backport StreamingCollectionEncoding for JSON and protobuf Oct 8, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 8, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 8, 2025 •
edited by openshift-ci bot
Loading

@rh-roman: This pull request references OCPSTRAT-2467 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature to target either version "4.18." or "openshift-4.18.", but it targets "openshift-4.21" instead.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rh-roman rh-roman changed the title [release-4.18] OCPSTRAT-2467: Backport StreamingCollectionEncoding for JSON and protobuf [release-4.18] CNTRLPLANE-1610: Backport StreamingCollectionEncoding for JSON and protobuf Oct 8, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 8, 2025 •
edited by openshift-ci bot
Loading

@rh-roman: This pull request references CNTRLPLANE-1610 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 9, 2025 •
edited by openshift-ci bot
Loading

@rh-roman: This pull request references CNTRLPLANE-1610 which is a valid jira issue.

In response to this:

Due to significant customer need for performance improvements related to API server pressure from large LIST requests, backporting the API streaming features that have been introduced in 1.33/1.34 related to kubernetes/enhancements#3157

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rh-roman
Copy link
Author

rh-roman commented Oct 9, 2025

/retest

@rh-roman rh-roman force-pushed the backport-api-stream-418 branch from 711c464 to 6664c46 Compare October 9, 2025 20:07
@openshift-ci-robot
Copy link

@rh-roman: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@rh-roman
Copy link
Author

/retest

@rh-roman rh-roman force-pushed the backport-api-stream-418 branch from 6664c46 to 70ca4ac Compare October 10, 2025 20:16
@openshift-ci-robot
Copy link

@rh-roman: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@benluddy
Copy link

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 10, 2025
@rh-roman
Copy link
Author

/retest

serathius and others added 3 commits October 13, 2025 14:51
@rh-roman rh-roman force-pushed the backport-api-stream-418 branch from 70ca4ac to 2c61e8e Compare October 13, 2025 21:52
@openshift-ci-robot
Copy link

@rh-roman: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 17, 2025 •
edited by openshift-ci bot
Loading

@rh-roman: This pull request references CNTRLPLANE-1610 which is a valid jira issue.

In response to this:

Due to significant customer need for performance improvements related to API server pressure from large LIST requests, backporting the API streaming features that have been introduced in 1.33/1.34 related to kubernetes/enhancements#3157

Metrics 4.18 vs 4.18 with StreamingCollectionEncoding enabled doc.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@benluddy
Copy link

/retest-required

@benluddy
Copy link

/lgtm
/label backport-risk-assessed
/remove-label backports/unvalidated-commits

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Oct 20, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2025
@benluddy
Copy link

/retest-required

@benluddy
Copy link

/label jira/valid-bug

@openshift-ci openshift-ci bot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 20, 2025
@benluddy
Copy link

/assign @bertinatto

@bertinatto
Copy link
Member

/approve

@bertinatto
Copy link
Member

/retest-required

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, bertinatto, rh-roman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2025
@kevinrizza
Copy link
Member

/retest-required

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 20, 2025

@rh-roman: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 2c61e8e link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-fips 2c61e8e link true /test e2e-aws-ovn-fips

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@jerpeter1 jerpeter1 Awaiting requested review from jerpeter1

1 more reviewer

@benluddy benluddy benluddy left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@benluddy benluddy

@bertinatto bertinatto

@kasturinarra kasturinarra

@zhouying7780 zhouying7780

@xingxingxia xingxingxia

@lyman9966 lyman9966

@duanwei33 duanwei33

@wangke19 wangke19

@gangwgr gangwgr

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. vendor-update Touching vendor dir or related files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.