[WIP] Skip CPU resource status for workload-pinned pods #2490
Conversation
openshift-ci-robot
added
the
backports/unvalidated-commits
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
@harche: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: harche The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| return nil, nil, err | ||
| } | ||
|
|
||
| isManagedPod := utilfeature.DefaultFeatureGate.Enabled(features.InPlacePodVerticalScaling) && managed.IsManagedPodFromRuntimeService(ctx, m.runtimeService, activePodSandboxID) |
There was a problem hiding this comment.
I don't think we need to check for feature gate here. cStatus.Resources != nil will only be true if the feature is enabled
|
|
||
| // IsPodSandboxManagedPod checks if a pod sandbox belongs to a managed pod | ||
| // by looking for workload pinning annotations. | ||
| func IsPodSandboxManagedPod(sandboxAnnotations map[string]string) bool { |
There was a problem hiding this comment.
nit: can this be defined below where it's called in IsManagedPodFromRuntimeService
Signed-off-by: Harshal Patil <[email protected]>
|
@harche: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@harche: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: