Bump openshift/api and mention failure.

[kannon92]

If we take the latest sha of openshift/api, we are hitting the following failure:

kehannon@kehannon-thinkpadp1gen4i:~/Work/openshift/kueue-operator$ make generate manifests
/home/kehannon/Work/openshift/kueue-operator/bin/controller-gen crd paths=./pkg/apis/kueueoperator/v1alpha1/... schemapatch:manifests=./manifests output:crd:dir=./manifests
/home/kehannon/Work/openshift/kueue-operator/vendor/github.com/openshift/api/operator/v1/types.go:261:1: unknown argument "optionalOldSelf" (at <input>:1:141)
/home/kehannon/Work/openshift/kueue-operator/vendor/github.com/openshift/api/operator/v1/types.go:261:1: extra arguments provided: "true,fieldPath=.currentRevision" (at <input>:1:142)
/home/kehannon/Work/openshift/kueue-operator/vendor/github.com/openshift/api/operator/v1/types.go:262:1: unknown argument "optionalOldSelf" (at <input>:1:139)
/home/kehannon/Work/openshift/kueue-operator/vendor/github.com/openshift/api/operator/v1/types.go:262:1: extra arguments provided: "true,fieldPath=.targetRevision" (at <input>:1:140)
/home/kehannon/Work/openshift/kueue-operator/vendor/github.com/openshift/api/operator/v1/types.go:261:1: unknown argument "optionalOldSelf" (at <input>:1:141)
/home/kehannon/Work/openshift/kueue-operator/vendor/github.com/openshift/api/operator/v1/types.go:261:1: extra arguments provided: "true,fieldPath=.currentRevision" (at <input>:1:142)
/home/kehannon/Work/openshift/kueue-operator/vendor/github.com/openshift/api/operator/v1/types.go:262:1: unknown argument "optionalOldSelf" (at <input>:1:139)
/home/kehannon/Work/openshift/kueue-operator/vendor/github.com/openshift/api/operator/v1/types.go:262:1: extra arguments provided: "true,fieldPath=.targetRevision" (at <input>:1:140)

Tracking this down, I think openshift/api@6b76c18 is causing an error for us.

cc @everettraven

Note, our CI says this passes because we don't check CRD generation yet.

[everettraven]

@kannon92 That looks like you may be using a version of controller-gen that doesn't have the changes to support the optionalOldSelf parameter on the kubebuilder:validationXValidation tag. It was introduced upstream by kubernetes-sigs/controller-tools#1150 and it seems like there hasn't been a release of the upstream controller-tools with these changes yet.

With this being an OpenShift repo, would it make sense to point the controller-gen reference in this repo to https://github.com/openshift/kubernetes-sigs-controller-tools ? We do have this change merged into this fork in the master and release-4.18 branches.

[kannon92]

@everettraven I'm having some trouble importing this.

kehannon@kehannon-thinkpadp1gen4i:~/Work/openshift/kueue-operator$ go get github.com/openshift/kubernetes-sigs-controller-tools@latest
go: github.com/openshift/kubernetes-sigs-controller-tools@latest (v0.12.0) requires github.com/openshift/kubernetes-sigs-controller-tools@v0.12.0: parsing go.mod:
	module declares its path as: sigs.k8s.io/controller-tools
	        but was required as: github.com/openshift/kubernetes-sigs-controller-tools

Any ideas on how to fix this?

[kannon92]

/hold cancel

[kannon92]

/retest

[kannon92]

Thank you to @everettraven!

He pointed out the fix and I think we are good to go with merging this.

We have to switch to controller-tools from openshift to get some patches that are tracking ahead of upstream.

cc @sohankunkerkar @PannagaRao

[kannon92]

/retest

[kannon92]

/retest

[kannon92]

/retest

[kannon92]

/retest

[kannon92]

/retest

[openshift-ci]

@kannon92: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[kannon92]

/cc @rphillips @PannagaRao

[PannagaRao]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kannon92, PannagaRao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [kannon92]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment