Skip to content

auditpolicycontroller: avoid unnecesary applyconfigmap calls #1987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

auditpolicycontroller: avoid unnecesary applyconfigmap calls #1987

wants to merge 2 commits into from

Conversation

vrutkovs
Copy link
Member

@vrutkovs vrutkovs commented Aug 4, 2025 •
edited
Loading

This would convert audit policy controller to use listers and compare contents with cached configmap to avoid extra apply calls.

Tested in openshift/cluster-kube-apiserver-operator#1886

@openshift-ci openshift-ci bot requested review from p0lyn0mial and tkashem August 4, 2025 11:03
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrutkovs
Once this PR has been reviewed and has the lgtm label, please assign tkashem for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrutkovs vrutkovs force-pushed the auditpolicycontroller-lister branch from 1fe75c8 to 3166f3b Compare August 4, 2025 12:46
@vrutkovs vrutkovs changed the title auditpolicycontroller: avoid unnecessray applyconfigmap calls WIP auditpolicycontroller: avoid unnecesary applyconfigmap calls Aug 4, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 4, 2025
@vrutkovs
auditpolicycontroller: avoid unnecessray applyconfigmap calls
a1cb8e0 
This would convert audit policy controller to use listers and compare contents with cached configmap
to avoid extra apply calls
@vrutkovs vrutkovs force-pushed the auditpolicycontroller-lister branch from 3166f3b to 936c427 Compare August 5, 2025 08:03
@vrutkovs
auditpolicycontroller: filter configmaps triggering this controller
0c1ebca 
Make sure that other configmap updates don't trigger auditpolicy controller - only target namespace
/ name configmap updates are making sync run. APIServer config and operator client informer events
are not being filtered
@vrutkovs vrutkovs force-pushed the auditpolicycontroller-lister branch from 936c427 to 0c1ebca Compare August 5, 2025 09:50
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 5, 2025

@vrutkovs: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vrutkovs vrutkovs changed the title WIP auditpolicycontroller: avoid unnecesary applyconfigmap calls auditpolicycontroller: avoid unnecesary applyconfigmap calls Aug 5, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

@tkashem tkashem Awaiting requested review from tkashem

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vrutkovs