-
Notifications
You must be signed in to change notification settings - Fork 244
OCPBUGS-59626: operator/v1helpers: add namespaced secret/configmap getters #2007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
OCPBUGS-59626: operator/v1helpers: add namespaced secret/configmap getters #2007
Conversation
Create new getters similar to CachedConfigMapGetter/CachedSecretGetter, but without a dependency on a cluster-level informer. This allows the operator to continue functioning when etcd has a corrupted key outside of target namespace. These new getters fall back to live client calls when a different namespace is being requested
Ensure that corruption of cluster-level cache doesn't affect static pod rollout
@vrutkovs: This pull request references Jira Issue OCPBUGS-59626, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vrutkovs The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@vrutkovs: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/jira refresh |
@vrutkovs: This pull request references Jira Issue OCPBUGS-59626, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Create new getters similar to CachedConfigMapGetter/CachedSecretGetter, but without a dependency on
a cluster-level informer. This allows the operator to continue functioning when etcd has a corrupted
key outside of target namespace. These new getters fall back to live client calls when a different
namespace is being requested.
Tested in openshift/cluster-kube-apiserver-operator#1916