STOR-2523: DeploymentVersionController: rename some fields and constructor arguments #2059
Conversation
…ents Names `deploymentInformer` and `controlPlaneKubeClient` looked misleading. They point to management cluster, so `managementClusterDeploymentInformer` and `managementClusterKubeClient` are better names.
openshift-ci-robot
added
the
jira/valid-reference
|
@mpatlasov: This pull request references STOR-2523 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.21." or "openshift-4.21.", but it targets "openshift-4.22" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@mpatlasov: GitHub didn't allow me to request PR reviews from the following users: openshift/storage. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mpatlasov The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@mpatlasov: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| controlPlaneNamespace string | ||
| controllerDeploymentName string | ||
| managementClusterDeploymentInformer appsinformersv1.DeploymentInformer | ||
| operatorClient v1helpers.OperatorClientWithFinalizers |
There was a problem hiding this comment.
should we rename this to guestClusterOperatorClient ?
3 participants
https://issues.redhat.com/browse/STOR-2523
/cc @openshift/storage
Names
deploymentInformerandcontrolPlaneKubeClientlooked misleading. They point to management cluster, somanagementClusterDeploymentInformerandmanagementClusterKubeClientare better names.