OCPVE-613: feat: switch to SSA for resource reconciliation

[jakobmoellerdev]

This is a sample implementation for SSA within lvm-operator and changes resource synchronization to no longer use Create/Update but use the k8s API Server for conflict resolution.

Open Issues:

• controller-runtime are still way behind on this topic and that Testing SSA with fake clients is not possible. Instead one has to create an interceptor: Support server-side apply (client.Apply) in fake Client kubernetes-sigs/controller-runtime#2341 (comment) for more info
• Applyconfiguration generation is not auto included in controller-tools so that needs to be worked around through an apply with a version injection. Current issue is open in ✨ Generation of typed apply clients using upstream generator kubernetes-sigs/controller-tools#818
• We will need a solid understanding of our Apply goals because without the above applyconfigurations we manually have to inject a GVK through the Prioritized Versions in our Scheme. Ideally this workaround is not necessary
• For Status Updates on live objects we will have to decide if we want to use a nil resourceVersion or if we want conflict recognition
• For Updates on live objects we will always manually need to nil out managedFields as SSA will fail with them included.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jakobmoellerdev
Once this PR has been reviewed and has the lgtm label, please assign jeff-roche for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jakobmoellerdev]

/test all

[openshift-ci-robot]

@jakobmoellerdev: This pull request references OCPVE-613 which is a valid jira issue.

Details

In response to this:

This is a sample implementation for SSA within lvm-operator and changes resource synchronization to no longer use Create/Update but use the k8s API Server for conflict resolution

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jakobmoellerdev]

/test lvm-operator-e2e-aws

[openshift-ci-robot]

@jakobmoellerdev: This pull request references OCPVE-613 which is a valid jira issue.

Details

In response to this:

This is a sample implementation for SSA within lvm-operator and changes resource synchronization to no longer use Create/Update but use the k8s API Server for conflict resolution.

Open Issues:

• controller-runtime are still way behind on this topic and that Testing SSA with fake clients is not possible. Instead one has to create an interceptor: Support server-side apply (client.Apply) in fake Client kubernetes-sigs/controller-runtime#2341 (comment) for more info
• Applyconfiguration generation is not auto included in controller-tools so that needs to be worked around through an apply with a version injection. Current issue is open in ✨ Generation of typed apply clients using upstream generator kubernetes-sigs/controller-tools#818
• We will need a solid understanding of our Apply goals because without the above applyconfigurations we manually have to inject a GVK through the Prioritized Versions in our Scheme. Ideally this workaround is not necessary
• For Status Updates on live objects we will have to decide if we want to use a nil resourceVersion or if we want conflict recognition
• For Updates on live objects we will always manually need to nil out managedFields as SSA will fail with them included.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-merge-robot]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@jakobmoellerdev: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/lvm-operator-e2e-aws-sno	99cbdf8	link	true	/test lvm-operator-e2e-aws-sno
ci/prow/lvm-operator-e2e-aws	99cbdf8	link	true	/test lvm-operator-e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jakobmoellerdev]

Closing due to too many open variables. Once a few more issues are closed and Applyconfiguration is available for kubebuilder based controllers I think we can give it another shot.