OCPBUGS-56168: [release-4.17] Update virtualmachines service to armcompute/v5 SDK

[mdbooth]

This replaces use of the legacy /services SDK for compute only in the virtualmachines service, with a minimal set of supporting changes. This allows using Azure APIs beyond those available via the legacy SDK.

(cherry picked from commit f76ad07)

Conflicts:

• pkg/cloud/azure/actuators/machine/reconciler.go
  • getPlatformFaultDomain is not present
• pkg/cloud/azure/actuators/machine/reconciler_test.go
  • No test for getPlatformFaultDomain
• pkg/cloud/azure/decode/virtualmachine.go
  • We deleted it anyway

(cherry picked from commit 51fbd9a)

Conflicts:

• go.mod
  • Trivial difference in grouping

Merge first:

• OCPBUGS-56167: [release-4.18] Update virtualmachines service to armcompute/v5 SDK #145

/hold

[openshift-ci-robot]

@mdbooth: This pull request references Jira Issue OCPBUGS-56168, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected dependent Jira Issue OCPBUGS-56167 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This replaces use of the legacy /services SDK for compute only in the virtualmachines service, with a minimal set of supporting changes. This allows using Azure APIs beyond those available via the legacy SDK.

(cherry picked from commit f76ad07)

Conflicts:

• pkg/cloud/azure/actuators/machine/reconciler.go

• getPlatformFaultDomain is not present

• pkg/cloud/azure/actuators/machine/reconciler_test.go

• No test for getPlatformFaultDomain

• pkg/cloud/azure/decode/virtualmachine.go

• We deleted it anyway

(cherry picked from commit 51fbd9a)

Conflicts:

• go.mod

• Trivial difference in grouping

Merge first:

• OCPBUGS-56167: [release-4.18] Update virtualmachines service to armcompute/v5 SDK #145

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign radekmanak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@mdbooth: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[damdo]

/assign @nrb @JoelSpeed

As you reviewed the previous one

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale