feature: Add support for data disks on Azure Stack Hub #149
Conversation
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @gcampbell12. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
This is fine in principal. I suspect that the only reason Stack Hub doesn't have this support is that there's a large amount of copy/paste in this repo and we just forgot Stack Hub when adding support for data disks.
With that in mind, assuming we don't want to backport this new feature I would prefer to merge #155 first, which eliminates a lot of the Stack Hub cut/paste in this package. With 2 exceptions that I've queried below, this would also allow the Stack Hub implementation to simply call the existing generateDataDisks method rather than creating yet another cut/paste.
If the 2 highlighted omissions aren't supported on Stack Hub, my preference would be to guard them in the common implementation with an if !stackHub and a comment explaining why rather than a full copy paste.
I'm fine with this feature as long as we can test it.
| "A Data Disk with `lun`: %d, already exists. `lun` must be unique.", | ||
| dataDiskName, vmSpec.Name, disk.Lun) | ||
| } | ||
|
|
There was a problem hiding this comment.
Was there a specific reason to omit support for DeletionPolicy here?
|
|
||
| dataDisks[i].ManagedDisk = &compute.ManagedDiskParameters{ | ||
| StorageAccountType: compute.StorageAccountTypes(disk.ManagedDisk.StorageAccountType), | ||
| } |
There was a problem hiding this comment.
Was there a specific reason to omit support for Disk Encryption Set here?
Guessing DES support is too new for Stack Hub's older API version?
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Is this a thing? /close Superceded by #156 |
|
@mdbooth: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Azure Stack Hub currently does not handle the
dataDisksfrom the provider spec and silently ignores this configuration, this PR will now handle these disks allowing Machines to be launched with attached data disks on Azure Stack Hub the handling of the data disks is largely mirrored from https://github.com/openshift/machine-api-provider-azure/blob/main/pkg/cloud/azure/services/virtualmachines/virtualmachines.go, with the addition of throwing an error if the user specifies an UltraDisk or disk encryption set since these do not appear to be supported used by the model currently used by the stack hub client.