Skip to content

Revert "TRT-2232: Revert #5148 "OCPBUGS-58023: Prevent unnecessary systemd unit disable"" #5225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Revert "TRT-2232: Revert #5148 "OCPBUGS-58023: Prevent unnecessary systemd unit disable"" #5225

wants to merge 1 commit into from

Conversation

RishabhSaini
Copy link
Contributor

Reverts #5213

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 6, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 6, 2025 •
edited by openshift-ci bot
Loading

@RishabhSaini: This pull request references TRT-2232 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Reverts #5213

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from djoshy and umohnani8 August 6, 2025 18:44
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RishabhSaini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2025
@RishabhSaini RishabhSaini force-pushed the revert-5213-revert-5148-1754043225154 branch 3 times, most recently from 5aca015 to cf1747a Compare August 7, 2025 13:45
@RishabhSaini
Revert "TRT-2232: Revert openshift#5148"
40304eb 
helpers: Compute systemdUnits that added and changed between Ign configs
update: Only write added or updated systemd units
on_disk_validation: Check if systemd units in config enabled correctly
@RishabhSaini RishabhSaini force-pushed the revert-5213-revert-5148-1754043225154 branch from cf1747a to 40304eb Compare August 7, 2025 13:46
@RishabhSaini
Copy link
Contributor Author

/test e2e-agnostic-ovn

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 29, 2025

@RishabhSaini: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test e2e-aws-ovn

/test e2e-aws-ovn-upgrade

/test e2e-gcp-op-1of2

/test e2e-gcp-op-2of2

/test e2e-gcp-op-single-node

/test e2e-hypershift

/test images

/test okd-scos-images

/test unit

/test verify

/test verify-deps

The following commands are available to trigger optional jobs:

/test bootstrap-unit

/test e2e-agent-compact-ipv4

/test e2e-aws-disruptive

/test e2e-aws-mco-disruptive

/test e2e-aws-ovn-fips

/test e2e-aws-ovn-fips-op

/test e2e-aws-ovn-ocb-techpreview

/test e2e-aws-ovn-serial-ipsec

/test e2e-aws-ovn-upgrade-ipsec

/test e2e-aws-ovn-upgrade-ocb-techpreview

/test e2e-aws-ovn-upgrade-out-of-change

/test e2e-aws-ovn-windows

/test e2e-aws-ovn-workers-rhel8

/test e2e-aws-proxy

/test e2e-aws-serial

/test e2e-aws-single-node

/test e2e-aws-upgrade-single-node

/test e2e-aws-workers-rhel8

/test e2e-azure

/test e2e-azure-ovn-upgrade

/test e2e-azure-ovn-upgrade-out-of-change

/test e2e-azure-upgrade

/test e2e-gcp-mco-disruptive

/test e2e-gcp-op

/test e2e-gcp-op-ocl

/test e2e-gcp-op-techpreview

/test e2e-gcp-ovn-rt-upgrade

/test e2e-gcp-rt

/test e2e-gcp-rt-op

/test e2e-gcp-single-node

/test e2e-gcp-upgrade

/test e2e-hypershift-techpreview

/test e2e-metal-assisted

/test e2e-metal-ipi-ovn-dualstack

/test e2e-metal-ipi-ovn-ipv6

/test e2e-metal-ovn-two-node-arbiter

/test e2e-metal-ovn-two-node-fencing

/test e2e-openstack

/test e2e-openstack-dualstack

/test e2e-openstack-externallb

/test e2e-openstack-hypershift

/test e2e-openstack-parallel

/test e2e-openstack-singlestackv6

/test e2e-ovirt

/test e2e-ovirt-upgrade

/test e2e-ovn-step-registry

/test e2e-vsphere

/test e2e-vsphere-ovn-upi

/test e2e-vsphere-ovn-upi-zones

/test e2e-vsphere-ovn-zones

/test e2e-vsphere-upgrade

/test okd-scos-e2e-aws-ovn

/test security

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-machine-config-operator-main-bootstrap-unit

pull-ci-openshift-machine-config-operator-main-e2e-agent-compact-ipv4

pull-ci-openshift-machine-config-operator-main-e2e-aws-mco-disruptive

pull-ci-openshift-machine-config-operator-main-e2e-aws-ovn

pull-ci-openshift-machine-config-operator-main-e2e-aws-ovn-upgrade

pull-ci-openshift-machine-config-operator-main-e2e-aws-ovn-upgrade-out-of-change

pull-ci-openshift-machine-config-operator-main-e2e-aws-ovn-windows

pull-ci-openshift-machine-config-operator-main-e2e-azure-ovn-upgrade-out-of-change

pull-ci-openshift-machine-config-operator-main-e2e-gcp-mco-disruptive

pull-ci-openshift-machine-config-operator-main-e2e-gcp-op-1of2

pull-ci-openshift-machine-config-operator-main-e2e-gcp-op-2of2

pull-ci-openshift-machine-config-operator-main-e2e-gcp-op-ocl

pull-ci-openshift-machine-config-operator-main-e2e-gcp-op-single-node

pull-ci-openshift-machine-config-operator-main-e2e-hypershift

pull-ci-openshift-machine-config-operator-main-images

pull-ci-openshift-machine-config-operator-main-okd-scos-e2e-aws-ovn

pull-ci-openshift-machine-config-operator-main-okd-scos-images

pull-ci-openshift-machine-config-operator-main-security

pull-ci-openshift-machine-config-operator-main-unit

pull-ci-openshift-machine-config-operator-main-verify

pull-ci-openshift-machine-config-operator-main-verify-deps

In response to this:

/test e2e-agnostic-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@RishabhSaini
Copy link
Contributor Author

/retest-required

@RishabhSaini
Copy link
Contributor Author

/test e2e-metal-ipi-ovn-ipv6

@RishabhSaini
Copy link
Contributor Author

/test e2e-azure-ovn-upgrade

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 29, 2025

@RishabhSaini: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-op-ocl 40304eb link false /test e2e-gcp-op-ocl
ci/prow/e2e-gcp-mco-disruptive 40304eb link false /test e2e-gcp-mco-disruptive
ci/prow/okd-scos-e2e-aws-ovn 40304eb link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-mco-disruptive 40304eb link false /test e2e-aws-mco-disruptive
ci/prow/e2e-aws-serial 40304eb link false /test e2e-aws-serial
ci/prow/e2e-azure-ovn-upgrade-out-of-change 40304eb link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/unit 40304eb link true /test unit
ci/prow/e2e-azure-ovn-upgrade 40304eb link false /test e2e-azure-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djoshy djoshy Awaiting requested review from djoshy

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RishabhSaini @openshift-ci-robot