MCO-1840: Remove MCN CRD cleanup cronjob

[djoshy]

This removes the cronjob introduced in #5215. This PR should only be merged after the 4.21 branch has taken place.

How to verify:
(This can be done without waiting for 4.21 branch)

• Launch a cluster on the latest 4.20 CI image
• Verify that the MCN cron job exists post installation:

$ oc get cronjob -n openshift-machine-config-operator
NAME                               SCHEDULE    TIMEZONE   SUSPEND   ACTIVE   LAST SCHEDULE   AGE
machine-config-nodes-crd-cleanup   * * * * *   <none>     True      0        66m             66m

• Upgrade to a 4.20 image with this PR
• Wait for the new MCO to roll out and all nodes to be updated. The upgrade should be complete; CVO (oc get clusterversion) should no longer be progressing.
• Check CVO logs to verify the delete:

I0808 17:58:56.774324       1 helper.go:65] Delete requested for cronjob "openshift-machine-config-operator/machine-config-nodes-crd-cleanup".
I0808 17:58:56.774360       1 sync_worker.go:1056] Done syncing for cronjob "openshift-machine-config-operator/machine-config-nodes-crd-cleanup" (954 of 981)
I0808 17:58:56.774388       1 sync_worker.go:1041] Running sync for clusterrolebinding "default-account-openshift-machine-config-operator" (955 of 981)
I0808 17:58:56.813753       1 helper.go:76] Delete of clusterrolebinding "default-account-openshift-machine-config-operator" completed.
I0808 17:58:56.813786       1 sync_worker.go:1056] Done syncing for clusterrolebinding "default-account-openshift-machine-config-operator" (955 of 981)
I0808 17:58:56.813806       1 sync_worker.go:1041] Running sync for cronjob "openshift-machine-config-operator/machine-config-nodes-crd-cleanup" (956 of 981)
I0808 17:58:56.864216       1 helper.go:76] Delete of cronjob "openshift-machine-config-operator/machine-config-nodes-crd-cleanup" completed.

• Check for the cronjob:

$ oc get cronjob -n openshift-machine-config-operator
No resources found in openshift-machine-config-operator namespace.

[openshift-ci-robot]

@djoshy: This pull request explicitly references no jira issue.

In response to this:

This removes the cronjob introduced in #5215. This PR should only be merged after the 4.21 branch has taken place.

How to verify:
(This can be done without waiting for 4.21 branch)

• Launch a cluster on the latest 4.20 CI image
• Verify that the MCN cron job exists post installation:

$ oc get cronjob -n openshift-machine-config-operator
NAME                               SCHEDULE    TIMEZONE   SUSPEND   ACTIVE   LAST SCHEDULE   AGE
machine-config-nodes-crd-cleanup   * * * * *   <none>     True      0        66m             66m

• Upgrade to a 4.20 image with this PR
• Wait for the new MCO to roll out and all nodes to be updated. The CVO (oc get clusterversion) should not longer be progressing.
• Check CVO logs to verify the delete:

I0808 17:58:56.774324       1 helper.go:65] Delete requested for cronjob "openshift-machine-config-operator/machine-config-nodes-crd-cleanup".
I0808 17:58:56.774360       1 sync_worker.go:1056] Done syncing for cronjob "openshift-machine-config-operator/machine-config-nodes-crd-cleanup" (954 of 981)
I0808 17:58:56.774388       1 sync_worker.go:1041] Running sync for clusterrolebinding "default-account-openshift-machine-config-operator" (955 of 981)
I0808 17:58:56.813753       1 helper.go:76] Delete of clusterrolebinding "default-account-openshift-machine-config-operator" completed.
I0808 17:58:56.813786       1 sync_worker.go:1056] Done syncing for clusterrolebinding "default-account-openshift-machine-config-operator" (955 of 981)
I0808 17:58:56.813806       1 sync_worker.go:1041] Running sync for cronjob "openshift-machine-config-operator/machine-config-nodes-crd-cleanup" (956 of 981)
I0808 17:58:56.864216       1 helper.go:76] Delete of cronjob "openshift-machine-config-operator/machine-config-nodes-crd-cleanup" completed.

• Check for the cronjob:

$ oc get cronjob
No resources found in openshift-machine-config-operator namespace.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[djoshy]

/hold

Throwing in a hold while we wait for the branch.

[isabella-janssen]

/retitle OCPBUGS-60306: Remove MCN CRD cleanup cronjob

[openshift-ci-robot]

@djoshy: This pull request references Jira Issue OCPBUGS-60306, which is invalid:

• expected the bug to target either version "4.20." or "openshift-4.20.", but it targets "4.21" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This removes the cronjob introduced in #5215. This PR should only be merged after the 4.21 branch has taken place.

How to verify:
(This can be done without waiting for 4.21 branch)

• Launch a cluster on the latest 4.20 CI image
• Verify that the MCN cron job exists post installation:

$ oc get cronjob -n openshift-machine-config-operator
NAME                               SCHEDULE    TIMEZONE   SUSPEND   ACTIVE   LAST SCHEDULE   AGE
machine-config-nodes-crd-cleanup   * * * * *   <none>     True      0        66m             66m

• Upgrade to a 4.20 image with this PR
• Wait for the new MCO to roll out and all nodes to be updated. The upgrade should be complete; CVO (oc get clusterversion) should no longer be progressing.
• Check CVO logs to verify the delete:

I0808 17:58:56.774324       1 helper.go:65] Delete requested for cronjob "openshift-machine-config-operator/machine-config-nodes-crd-cleanup".
I0808 17:58:56.774360       1 sync_worker.go:1056] Done syncing for cronjob "openshift-machine-config-operator/machine-config-nodes-crd-cleanup" (954 of 981)
I0808 17:58:56.774388       1 sync_worker.go:1041] Running sync for clusterrolebinding "default-account-openshift-machine-config-operator" (955 of 981)
I0808 17:58:56.813753       1 helper.go:76] Delete of clusterrolebinding "default-account-openshift-machine-config-operator" completed.
I0808 17:58:56.813786       1 sync_worker.go:1056] Done syncing for clusterrolebinding "default-account-openshift-machine-config-operator" (955 of 981)
I0808 17:58:56.813806       1 sync_worker.go:1041] Running sync for cronjob "openshift-machine-config-operator/machine-config-nodes-crd-cleanup" (956 of 981)
I0808 17:58:56.864216       1 helper.go:76] Delete of cronjob "openshift-machine-config-operator/machine-config-nodes-crd-cleanup" completed.

• Check for the cronjob:

$ oc get cronjob -n openshift-machine-config-operator
No resources found in openshift-machine-config-operator namespace.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@djoshy: This pull request references MCO-1840 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

This removes the cronjob introduced in #5215. This PR should only be merged after the 4.21 branch has taken place.

How to verify:
(This can be done without waiting for 4.21 branch)

• Launch a cluster on the latest 4.20 CI image
• Verify that the MCN cron job exists post installation:

$ oc get cronjob -n openshift-machine-config-operator
NAME                               SCHEDULE    TIMEZONE   SUSPEND   ACTIVE   LAST SCHEDULE   AGE
machine-config-nodes-crd-cleanup   * * * * *   <none>     True      0        66m             66m

• Upgrade to a 4.20 image with this PR
• Wait for the new MCO to roll out and all nodes to be updated. The upgrade should be complete; CVO (oc get clusterversion) should no longer be progressing.
• Check CVO logs to verify the delete:

I0808 17:58:56.774324       1 helper.go:65] Delete requested for cronjob "openshift-machine-config-operator/machine-config-nodes-crd-cleanup".
I0808 17:58:56.774360       1 sync_worker.go:1056] Done syncing for cronjob "openshift-machine-config-operator/machine-config-nodes-crd-cleanup" (954 of 981)
I0808 17:58:56.774388       1 sync_worker.go:1041] Running sync for clusterrolebinding "default-account-openshift-machine-config-operator" (955 of 981)
I0808 17:58:56.813753       1 helper.go:76] Delete of clusterrolebinding "default-account-openshift-machine-config-operator" completed.
I0808 17:58:56.813786       1 sync_worker.go:1056] Done syncing for clusterrolebinding "default-account-openshift-machine-config-operator" (955 of 981)
I0808 17:58:56.813806       1 sync_worker.go:1041] Running sync for cronjob "openshift-machine-config-operator/machine-config-nodes-crd-cleanup" (956 of 981)
I0808 17:58:56.864216       1 helper.go:76] Delete of cronjob "openshift-machine-config-operator/machine-config-nodes-crd-cleanup" completed.

• Check for the cronjob:

$ oc get cronjob -n openshift-machine-config-operator
No resources found in openshift-machine-config-operator namespace.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[isabella-janssen]

/lgtm

Now that 4.20 branching is complete, this PR should be ready to go & it looks fair to me!

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, isabella-janssen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [djoshy,isabella-janssen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[djoshy]

/test all

[openshift-ci]

@djoshy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure-ovn-upgrade	d88959a	link	false	/test e2e-azure-ovn-upgrade
ci/prow/e2e-aws-serial	d88959a	link	false	/test e2e-aws-serial
ci/prow/e2e-aws-mco-disruptive	715f38d	link	false	/test e2e-aws-mco-disruptive
ci/prow/e2e-gcp-op-2of2	715f38d	link	true	/test e2e-gcp-op-2of2
ci/prow/unit	715f38d	link	true	/test unit
ci/prow/e2e-gcp-op-ocl	715f38d	link	false	/test e2e-gcp-op-ocl
ci/prow/e2e-aws-ovn-windows	715f38d	link	false	/test e2e-aws-ovn-windows
ci/prow/e2e-gcp-mco-disruptive	715f38d	link	false	/test e2e-gcp-mco-disruptive
ci/prow/e2e-gcp-op-1of2	715f38d	link	true	/test e2e-gcp-op-1of2
ci/prow/e2e-azure-ovn-upgrade-out-of-change	715f38d	link	false	/test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-hypershift	715f38d	link	true	/test e2e-hypershift
ci/prow/e2e-gcp-op-single-node	715f38d	link	true	/test e2e-gcp-op-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.