Skip to content

Testing pr #5240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Testing pr #5240

wants to merge 4 commits into from

Conversation

MaysaMacedo
Copy link
Contributor

- What I did

- How to verify it

- Description for the changelog

@MaysaMacedo
OCPBUGS-57979: Update Kubelet Config MachineConfig upon FeatureGate u…
a9ad0c1 
…pdate

When a KubeletConfig is created a MachineConfig named 99-worker-generated-kubelet
gets created, also when a FeatureGate is updated the MachineConfigs
named 97-worker-generated-kubelet and 98-worker-generated-kubelet get updated.
The final rendered MachineConfig that is applied to the Nodes is a merge of the
MachineConfig in order. The 99-worker-generated-kubelet is the last kubelet related
machineconfig merged and it has wrong feature gates, which makes the final rendered
machineconfig to have wrong featuregates enabled. This commit fixes the issue by
ensuring that the 99-worker-generated-kubelet machineconfig also gets updated when
a feature gate is updated.
@MaysaMacedo
Improve logic and fix unit tests
cd87e1e
@MaysaMacedo
Include unit tests
f941395
@MaysaMacedo
adding log
caeb4b4
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 11, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 11, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MaysaMacedo
Once this PR has been reviewed and has the lgtm label, please assign dkhater-redhat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 23, 2025
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaysaMacedo @openshift-merge-robot