Skip to content

Conversation

martinkennelly
Copy link
Contributor

/hold
/cc

Production of image only

…et it

This fixes the issue where ovn-remote is set
prior to reboot and when boot occurs, ovn-controller
syncs quickly with a stale SB DB.

This PR is part of the EIP GARP issue fix.
Its required because when ovnkube-controller and
ovn-controller container start on boot, there
is no order to which container will start first,
and we dont want ovn-controller to connect to SB DB
before ovnkube controller has added the drop flows.

Ideally, we would only allow ovn-controller to sync
with SB DB when ovnkube controller has concluded
syncing and the changes are available in SB DB.
That maybe future work.

Signed-off-by: Martin Kennelly <[email protected]>
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 14, 2025
Copy link
Contributor

openshift-ci bot commented Aug 14, 2025

@martinkennelly: GitHub didn't allow me to request PR reviews from the following users: martinkennelly.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/hold
/cc

Production of image only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Aug 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: martinkennelly
Once this PR has been reviewed and has the lgtm label, please assign dkhater-redhat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Aug 14, 2025

@martinkennelly: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-op-techpreview 8c94614 link false /test e2e-gcp-op-techpreview
ci/prow/e2e-gcp-op 8c94614 link true /test e2e-gcp-op
ci/prow/images 8c94614 link true /test images
ci/prow/okd-scos-e2e-aws-ovn 8c94614 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-hypershift 8c94614 link true /test e2e-hypershift
ci/prow/e2e-gcp-op-single-node 8c94614 link true /test e2e-gcp-op-single-node
ci/prow/e2e-azure-ovn-upgrade-out-of-change 8c94614 link false /test e2e-azure-ovn-upgrade-out-of-change

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant