OCPBUGS-60120: Add nil/null checks to image registry secret decode

[yuqi-zhang]

The MCO pod can sometimes panic early on, seemingly with an empty docker config json. Not sure if it's the json null literal, or if the decode removed unknown fields to end up empty, so adding a check for both.

[openshift-ci-robot]

@yuqi-zhang: This pull request references Jira Issue OCPBUGS-60120, which is invalid:

• expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The MCO pod can sometimes panic early on, seemingly with an empty docker config json. Not sure if it's the json null literal, or if the decode removed unknown fields to end up empty, so adding a check for both.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@yuqi-zhang: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/bootstrap-unit	3f27444	link	false	/test bootstrap-unit
ci/prow/okd-scos-e2e-aws-ovn	3f27444	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/e2e-gcp-op-ocl	3f27444	link	false	/test e2e-gcp-op-ocl
ci/prow/e2e-aws-ovn-upgrade-out-of-change	3f27444	link	false	/test e2e-aws-ovn-upgrade-out-of-change
ci/prow/e2e-gcp-mco-disruptive	3f27444	link	false	/test e2e-gcp-mco-disruptive
ci/prow/e2e-aws-mco-disruptive	3f27444	link	false	/test e2e-aws-mco-disruptive
ci/prow/e2e-aws-ovn	3f27444	link	true	/test e2e-aws-ovn
ci/prow/e2e-azure-ovn-upgrade-out-of-change	3f27444	link	false	/test e2e-azure-ovn-upgrade-out-of-change

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[yuqi-zhang]

/jira refresh

[openshift-ci-robot]

@yuqi-zhang: This pull request references Jira Issue OCPBUGS-60120, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.0) matches configured target version for branch (4.20.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[djoshy]

/lgtm

This seems sane to me, wonder what changed recently to cause these panics now. This code is somewhat old now IIUC?

/hold

Holding for QE review, but feel free to unhold if you don't think it requires pre merge testing

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [djoshy,yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ptalgulk01]

Pre-merge tested by deploying below CI jobs for which panic was seen.

• GCP jobs
  P1, P2 ,P3

• Vsphere IPI Jobs
  G1, G2

• AWS IPI job
  P1, P2, P3

No Panic observed for above CI job
/label qe-approved

[openshift-ci-robot]

@yuqi-zhang: This pull request references Jira Issue OCPBUGS-60120, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.0) matches configured target version for branch (4.20.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

In response to this:

The MCO pod can sometimes panic early on, seemingly with an empty docker config json. Not sure if it's the json null literal, or if the decode removed unknown fields to end up empty, so adding a check for both.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

[openshift-ci-robot]

@openshift-bot: This pull request references Jira Issue OCPBUGS-60120, which is invalid:

• expected the bug to target either version "4.21." or "openshift-4.21.", but it targets "4.20.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.