-
Notifications
You must be signed in to change notification settings - Fork 443
MCO-1673: Add Component Readiness tests for Azure boot image updates #5257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@djoshy: This pull request references MCO-1673 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: djoshy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/payload-job periodic-ci-openshift-machine-config-operator-release-4.20-periodics-e2e-azure-mco-disruptive-techpreview |
@djoshy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/10b5b2b0-7df8-11f0-96b2-76eddb4322a3-0 |
ad733d2
to
a45b7b9
Compare
/payload-job periodic-ci-openshift-machine-config-operator-release-4.20-periodics-e2e-azure-mco-disruptive-techpreview |
@djoshy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/02096220-7e9d-11f0-8a13-a2f484bfc69b-0 |
/payload-job periodic-ci-openshift-machine-config-operator-release-4.20-periodics-e2e-azure-mco-disruptive-techpreview |
@djoshy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/387415b0-7ea9-11f0-9b0e-540f5e4e23bc-0 |
/payload-job periodic-ci-openshift-machine-config-operator-release-4.20-periodics-e2e-azure-mco-disruptive-techpreview |
@djoshy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/371061d0-7ebb-11f0-9896-17e55b35122e-0 |
/payload-job periodic-ci-openshift-machine-config-operator-release-4.20-periodics-e2e-azure-mco-disruptive-techpreview |
@djoshy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/07d35480-7ec6-11f0-8b2f-c076727a26d5-0 |
/payload-aggregate periodic-ci-openshift-machine-config-operator-release-4.20-periodics-e2e-azure-mco-disruptive-techpreview 5 |
@djoshy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/637d8500-7f5a-11f0-9992-bbe91691992a-0 |
This commit enables the boot image controller when the ManagedBootImagesAzure feature gate is enabled AND when the Azure platform is detected. It also updates the ValidatingAdmissionPolicy to permit opting in the cluster for boot image updates while on the Azure platform.
a45b7b9
to
bdb44d0
Compare
/payload-job periodic-ci-openshift-machine-config-operator-release-4.20-periodics-e2e-azure-mco-disruptive-techpreview |
@djoshy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ed4f7950-81f3-11f0-85b0-8d59f8c6bc4f-0 |
/payload-aggregate periodic-ci-openshift-machine-config-operator-release-4.20-periodics-e2e-azure-mco-disruptive-techpreview 5 |
@djoshy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ab2d3710-827f-11f0-965b-a0a263c23e51-0 |
bdb44d0
to
d4bf670
Compare
This commit enables Azure platform support in the machine set boot image controller by implementing reconcileAzureProviderSpec. It transitions clusters with legacy uploaded images to marketplace images.
This commit adds unit tests for the various Azure image flavors.
d4bf670
to
db8cf9e
Compare
@djoshy: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR is currently only open for review/testing purposes and should only be merged after #5202 lands.
Only the last commit should be relevant for review; commit 31d5971 should be removed prior to merge and is only in-place to provide a fixed source for boot images until openshift/installer#9329 lands. The other commits are pulled from #5202 to enable the actual boot image mechanism.
This PR adds 5 CR tests for Azure boot image updates to the MCO's extended test suite. These include the Azure variant of the tests we've used for other platforms in origin, and an additional test to ensure that migration from a legacy image to a marketplace image works as expected.