Skip to content

Conversation

djoshy
Copy link
Contributor

@djoshy djoshy commented Aug 20, 2025

This PR is currently only open for review/testing purposes and should only be merged after #5202 lands.

Only the last commit should be relevant for review; commit 31d5971 should be removed prior to merge and is only in-place to provide a fixed source for boot images until openshift/installer#9329 lands. The other commits are pulled from #5202 to enable the actual boot image mechanism.

This PR adds 5 CR tests for Azure boot image updates to the MCO's extended test suite. These include the Azure variant of the tests we've used for other platforms in origin, and an additional test to ensure that migration from a legacy image to a marketplace image works as expected.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 20, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 20, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 20, 2025

@djoshy: This pull request references MCO-1673 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

This PR is currently only open for review/testing purposes and should only be merged after #5202 lands.

Only the last commit should be relevant for review; commit 31d5971 should be removed prior to merge and is only in-place to provide a fixed source for boot images until openshift/installer#9329 lands. The other commits are pulled from #5202 to enable the actual boot image mechanism.

This PR adds 5 CR tests for Azure boot image updates to the MCO's extended test suite. These include the Azure variant of the tests we've used for other platforms in origin, and an additional test to ensure that migration from a legacy image to a marketplace image works as expected.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Aug 20, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Aug 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2025
@djoshy
Copy link
Contributor Author

djoshy commented Aug 20, 2025

/payload-job periodic-ci-openshift-machine-config-operator-release-4.20-periodics-e2e-azure-mco-disruptive-techpreview

Copy link
Contributor

openshift-ci bot commented Aug 20, 2025

@djoshy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-machine-config-operator-release-4.20-periodics-e2e-azure-mco-disruptive-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/10b5b2b0-7df8-11f0-96b2-76eddb4322a3-0

@djoshy djoshy changed the title MCO-1673: Add origin e2es for Azure boot image updates MCO-1673: Add Component Readiness tests for Azure boot image updates Aug 20, 2025
@djoshy djoshy force-pushed the add-azure-cr-tests branch from ad733d2 to a45b7b9 Compare August 21, 2025 14:35
@djoshy
Copy link
Contributor Author

djoshy commented Aug 21, 2025

/payload-job periodic-ci-openshift-machine-config-operator-release-4.20-periodics-e2e-azure-mco-disruptive-techpreview

Copy link
Contributor

openshift-ci bot commented Aug 21, 2025

@djoshy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-machine-config-operator-release-4.20-periodics-e2e-azure-mco-disruptive-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/02096220-7e9d-11f0-8a13-a2f484bfc69b-0

@djoshy
Copy link
Contributor Author

djoshy commented Aug 21, 2025

/payload-job periodic-ci-openshift-machine-config-operator-release-4.20-periodics-e2e-azure-mco-disruptive-techpreview

Copy link
Contributor

openshift-ci bot commented Aug 21, 2025

@djoshy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-machine-config-operator-release-4.20-periodics-e2e-azure-mco-disruptive-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/387415b0-7ea9-11f0-9b0e-540f5e4e23bc-0

@djoshy
Copy link
Contributor Author

djoshy commented Aug 21, 2025

/payload-job periodic-ci-openshift-machine-config-operator-release-4.20-periodics-e2e-azure-mco-disruptive-techpreview

Copy link
Contributor

openshift-ci bot commented Aug 21, 2025

@djoshy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-machine-config-operator-release-4.20-periodics-e2e-azure-mco-disruptive-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/371061d0-7ebb-11f0-9896-17e55b35122e-0

@djoshy
Copy link
Contributor Author

djoshy commented Aug 21, 2025

/payload-job periodic-ci-openshift-machine-config-operator-release-4.20-periodics-e2e-azure-mco-disruptive-techpreview

Copy link
Contributor

openshift-ci bot commented Aug 21, 2025

@djoshy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-machine-config-operator-release-4.20-periodics-e2e-azure-mco-disruptive-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/07d35480-7ec6-11f0-8b2f-c076727a26d5-0

@djoshy
Copy link
Contributor Author

djoshy commented Aug 22, 2025

/payload-aggregate periodic-ci-openshift-machine-config-operator-release-4.20-periodics-e2e-azure-mco-disruptive-techpreview 5

Copy link
Contributor

openshift-ci bot commented Aug 22, 2025

@djoshy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-machine-config-operator-release-4.20-periodics-e2e-azure-mco-disruptive-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/637d8500-7f5a-11f0-9992-bbe91691992a-0

djoshy added 2 commits August 25, 2025 11:59
This commit enables the boot image controller when the
ManagedBootImagesAzure feature gate is enabled AND when the Azure
platform is detected. It also updates the ValidatingAdmissionPolicy to
permit opting in the cluster for boot image updates while on the Azure
platform.
@djoshy djoshy force-pushed the add-azure-cr-tests branch from a45b7b9 to bdb44d0 Compare August 25, 2025 20:41
@djoshy
Copy link
Contributor Author

djoshy commented Aug 25, 2025

/payload-job periodic-ci-openshift-machine-config-operator-release-4.20-periodics-e2e-azure-mco-disruptive-techpreview

Copy link
Contributor

openshift-ci bot commented Aug 25, 2025

@djoshy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-machine-config-operator-release-4.20-periodics-e2e-azure-mco-disruptive-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ed4f7950-81f3-11f0-85b0-8d59f8c6bc4f-0

@djoshy djoshy marked this pull request as ready for review August 26, 2025 13:21
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 26, 2025
@djoshy
Copy link
Contributor Author

djoshy commented Aug 26, 2025

/payload-aggregate periodic-ci-openshift-machine-config-operator-release-4.20-periodics-e2e-azure-mco-disruptive-techpreview 5

Copy link
Contributor

openshift-ci bot commented Aug 26, 2025

@djoshy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-machine-config-operator-release-4.20-periodics-e2e-azure-mco-disruptive-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ab2d3710-827f-11f0-965b-a0a263c23e51-0

@openshift-ci openshift-ci bot requested a review from RishabhSaini August 26, 2025 13:23
@openshift-ci openshift-ci bot requested a review from umohnani8 August 26, 2025 13:23
@djoshy djoshy force-pushed the add-azure-cr-tests branch from bdb44d0 to d4bf670 Compare August 26, 2025 14:11
djoshy added 3 commits August 27, 2025 10:00
This commit enables Azure platform support in the machine set boot image
controller by implementing reconcileAzureProviderSpec. It
transitions clusters with legacy uploaded images to marketplace images.
This commit adds unit tests for the various Azure image flavors.
@djoshy djoshy force-pushed the add-azure-cr-tests branch from d4bf670 to db8cf9e Compare August 27, 2025 14:09
Copy link
Contributor

openshift-ci bot commented Aug 27, 2025

@djoshy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-op-ocl db8cf9e link false /test e2e-gcp-op-ocl
ci/prow/e2e-azure-ovn-upgrade-out-of-change db8cf9e link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-aws-mco-disruptive db8cf9e link false /test e2e-aws-mco-disruptive
ci/prow/bootstrap-unit db8cf9e link false /test bootstrap-unit
ci/prow/e2e-gcp-mco-disruptive db8cf9e link false /test e2e-gcp-mco-disruptive

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants