Skip to content

Conversation

isabella-janssen
Copy link
Member

@isabella-janssen isabella-janssen commented Aug 21, 2025

Closes: OCPBUGS-60767

- What I did
This is a manual cherrypick of #5249 since the automated cherrypick failed. This backport is required since we are backporting the API validation rule requiring MCP & MOSC names to match (see openshift/api#2449).

- How to verify it
The OnClusterBuild tests in the MCO disruptive test suite triggered against the API backport PR introducing the new validation rule should not fail with the following error, MachineOSConfig name must match the referenced MachineConfigPool name; can only have one MachineOSConfig per MachineConfigPool.

See payload test: https://pr-payload-tests.ci.openshift.org/runs/ci/9788cd30-7e94-11f0-8c45-45136dc11bb6-0

- Description for the changelog
OCPBUGS-60559: Update the OnClusterBuild tests to reflect validation rule requiring the MOSC and MCP names to match

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2025
@isabella-janssen
Copy link
Member Author

/jira cherry-pick OCPBUGS-60559

@openshift-ci-robot
Copy link
Contributor

@isabella-janssen: Jira Issue OCPBUGS-60559 has been cloned as Jira Issue OCPBUGS-60767. Will retitle bug to link to clone.
/retitle OCPBUGS-60767: Update the OnClusterBuild payload tests to reflect the validation rule requiring MCP & MOSC names to match

In response to this:

/jira cherry-pick OCPBUGS-60559

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title Update the OnClusterBuild payload tests to reflect the validation rule requiring MCP & MOSC names to match OCPBUGS-60767: Update the OnClusterBuild payload tests to reflect the validation rule requiring MCP & MOSC names to match Aug 21, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Aug 21, 2025
@openshift-ci-robot
Copy link
Contributor

@isabella-janssen: This pull request references Jira Issue OCPBUGS-60767, which is invalid:

  • expected dependent Jira Issue OCPBUGS-60559 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

…g names

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 21, 2025
@isabella-janssen
Copy link
Member Author

/payload-job periodic-ci-openshift-machine-config-operator-release-4.19-periodics-e2e-vsphere-mco-disruptive periodic-ci-openshift-machine-config-operator-release-4.19-periodics-e2e-aws-mco-disruptive periodic-ci-openshift-machine-config-operator-release-4.19-periodics-e2e-azure-mco-disruptive periodic-ci-openshift-machine-config-operator-release-4.19-periodics-e2e-gcp-mco-disruptive

Copy link
Contributor

openshift-ci bot commented Aug 21, 2025

@isabella-janssen: trigger 4 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-machine-config-operator-release-4.19-periodics-e2e-vsphere-mco-disruptive
  • periodic-ci-openshift-machine-config-operator-release-4.19-periodics-e2e-aws-mco-disruptive
  • periodic-ci-openshift-machine-config-operator-release-4.19-periodics-e2e-azure-mco-disruptive
  • periodic-ci-openshift-machine-config-operator-release-4.19-periodics-e2e-gcp-mco-disruptive

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ce04f8d0-7e93-11f0-91dc-c4b9351690a8-0

Copy link
Contributor

openshift-ci bot commented Aug 21, 2025

@isabella-janssen: This PR was included in a payload test run from openshift/api#2449
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-machine-config-operator-release-4.19-periodics-e2e-aws-mco-disruptive

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9788cd30-7e94-11f0-8c45-45136dc11bb6-0

@umohnani8
Copy link
Contributor

Thanks @isabella-jansse! LGTM

@isabella-janssen isabella-janssen changed the title OCPBUGS-60767: Update the OnClusterBuild payload tests to reflect the validation rule requiring MCP & MOSC names to match [release-4.19] OCPBUGS-60767: Update the OnClusterBuild payload tests to reflect the validation rule requiring MCP & MOSC names to match Aug 28, 2025
@isabella-janssen
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 28, 2025
@openshift-ci-robot
Copy link
Contributor

@isabella-janssen: This pull request references Jira Issue OCPBUGS-60767, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.z) matches configured target version for branch (4.19.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-60559 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-60559 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
  • bug has dependents

Requesting review from QA contact:
/cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sergiordlr August 28, 2025 12:55
@RishabhSaini
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2025
@pablintino
Copy link
Contributor

/lgtm

Copy link
Contributor

openshift-ci bot commented Aug 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isabella-janssen, pablintino, RishabhSaini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [RishabhSaini,isabella-janssen,pablintino]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@isabella-janssen
Copy link
Member Author

/label backport-risk-assessed

The scope of this change is limited to the OnClusterBuild regression tests & rehearsal payloads tests have been run.

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 28, 2025
@isabella-janssen
Copy link
Member Author

/test unit

Copy link
Contributor

openshift-ci bot commented Aug 28, 2025

@isabella-janssen: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit f56b790 into openshift:release-4.19 Aug 28, 2025
19 of 20 checks passed
@openshift-ci-robot
Copy link
Contributor

@isabella-janssen: Jira Issue OCPBUGS-60767: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-60767 has been moved to the MODIFIED state.

In response to this:

Closes: OCPBUGS-60767

- What I did
This is a manual cherrypick of #5249 since the automated cherrypick failed. This backport is required since we are backporting the API validation rule requiring MCP & MOSC names to match (see openshift/api#2449).

- How to verify it
The OnClusterBuild tests in the MCO disruptive test suite triggered against the API backport PR introducing the new validation rule should not fail with the following error, MachineOSConfig name must match the referenced MachineConfigPool name; can only have one MachineOSConfig per MachineConfigPool.

See payload test: https://pr-payload-tests.ci.openshift.org/runs/ci/9788cd30-7e94-11f0-8c45-45136dc11bb6-0

- Description for the changelog
OCPBUGS-60559: Update the OnClusterBuild tests to reflect validation rule requiring the MOSC and MCP names to match

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-config-operator
This PR has been included in build ose-machine-config-operator-container-v4.19.0-202508281608.p0.gf56b790.assembly.stream.el9.
All builds following this will include this PR.

@isabella-janssen isabella-janssen deleted the 419-mosc-test-names branch August 28, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.