-
Notifications
You must be signed in to change notification settings - Fork 443
[release-4.19] OCPBUGS-60767: Update the OnClusterBuild payload tests to reflect the validation rule requiring MCP & MOSC names to match #5258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/jira cherry-pick OCPBUGS-60559 |
@isabella-janssen: Jira Issue OCPBUGS-60559 has been cloned as Jira Issue OCPBUGS-60767. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@isabella-janssen: This pull request references Jira Issue OCPBUGS-60767, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/payload-job periodic-ci-openshift-machine-config-operator-release-4.19-periodics-e2e-vsphere-mco-disruptive periodic-ci-openshift-machine-config-operator-release-4.19-periodics-e2e-aws-mco-disruptive periodic-ci-openshift-machine-config-operator-release-4.19-periodics-e2e-azure-mco-disruptive periodic-ci-openshift-machine-config-operator-release-4.19-periodics-e2e-gcp-mco-disruptive |
@isabella-janssen: trigger 4 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ce04f8d0-7e93-11f0-91dc-c4b9351690a8-0 |
@isabella-janssen: This PR was included in a payload test run from openshift/api#2449
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9788cd30-7e94-11f0-8c45-45136dc11bb6-0 |
Thanks @isabella-jansse! LGTM |
/jira refresh |
@isabella-janssen: This pull request references Jira Issue OCPBUGS-60767, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: isabella-janssen, pablintino, RishabhSaini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label backport-risk-assessed The scope of this change is limited to the OnClusterBuild regression tests & rehearsal payloads tests have been run. |
/test unit |
@isabella-janssen: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
f56b790
into
openshift:release-4.19
@isabella-janssen: Jira Issue OCPBUGS-60767: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-60767 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] Distgit: ose-machine-config-operator |
Closes: OCPBUGS-60767
- What I did
This is a manual cherrypick of #5249 since the automated cherrypick failed. This backport is required since we are backporting the API validation rule requiring MCP & MOSC names to match (see openshift/api#2449).
- How to verify it
The OnClusterBuild tests in the MCO disruptive test suite triggered against the API backport PR introducing the new validation rule should not fail with the following error,
MachineOSConfig name must match the referenced MachineConfigPool name; can only have one MachineOSConfig per MachineConfigPool
.See payload test: https://pr-payload-tests.ci.openshift.org/runs/ci/9788cd30-7e94-11f0-8c45-45136dc11bb6-0
- Description for the changelog
OCPBUGS-60559: Update the OnClusterBuild tests to reflect validation rule requiring the MOSC and MCP names to match