OCPBUGS-56558: Recheck generatedByControllerVersion annotation prior to deleting a degraded MC
#5259
Conversation
openshift-ci-robot
added
jira/severity-important
|
@RishabhSaini: This pull request references Jira Issue OCPBUGS-56558, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@RishabhSaini: This pull request references Jira Issue OCPBUGS-56558, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
/lgtm
Discussed this with Rishabh, the issue does appear to be an outdated MC from the lister, so the additional get() here should be sufficient since this should almost never happen.
The delete condition may be a bit loose since the comment suggests that we should only be deleting the MC if it is causing a degrade, but we're not really accounting for a non-upgradeable CRC and just deleting it if the annotation is from an older controller. Worth keeping in mind if this comes up again.
/hold
for per-merge verification
openshift-ci
bot
added
the
do-not-merge/hold
openshift-ci
bot
added
lgtm
|
/retest-required |
have not been updated since the last check
RishabhSaini
force-pushed
the
crcMissing
branch
from
0b5d6fc to
c2c1b70
Compare
|
@RishabhSaini: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: isabella-janssen, RishabhSaini, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/jira refresh The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity. |
openshift-ci-robot
added
jira/invalid-bug
|
@openshift-bot: This pull request references Jira Issue OCPBUGS-56558, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@yuqi-zhang: This pull request references Jira Issue OCPBUGS-56558, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
After discussions, we've determined that this is hard to pre-merge verify as the race is very rare. The fix should otherwise be safe, so will go ahead and merge and try to backport since it is a critical issue for customers that hit this. /label acknowledge-critical-fixes-only |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
|
/cherry-pick release-4.20 |
|
@yuqi-zhang: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/verified later @yuqi-zhang |
openshift-ci-robot
added
verified-later
verified
|
@yuqi-zhang: This PR has been marked to be verified later by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
openshift-merge-bot
bot
merged commit 0634552
into
openshift:main
|
@RishabhSaini: Jira Issue OCPBUGS-56558: Some pull requests linked via external trackers have merged: The following pull request, linked via external tracker, has not merged: All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-56558 has not been moved to the MODIFIED state. This PR is marked as verified-later. Jira issue(s) in the title of this PR will require post-merge verification. After testing, it must be manually moved to the In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@yuqi-zhang: new pull request created: #5273 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
- What I did
crc & kcc: Before deleting a degraded MC, ensure that the annotations have not been updated since the last check
- How to verify it
Check OCPBUGS-56558
- Description for the changelog