Skip to content

[release-4.17] OCPBUGS-60890: Race in configure-ovs.sh affects bonding interface configuration. #5267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: release-4.17
Choose a base branch
from
Open

[release-4.17] OCPBUGS-60890: Race in configure-ovs.sh affects bonding interface configuration. #5267

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28ceb6e
Race in configure-ovs.sh affects bonding interface configuration.
DaveWilder Sep 23, 2024
5dccc60
Revert "Race in configure-ovs.sh affects bonding interface configurat…
DaveWilder Dec 9, 2024
cb5faf3
Give bonding slaves time to implicitly activate.
DaveWilder Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions templates/common/_base/files/configure-ovs-network.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,6 +576,13 @@ contents:
fi
fi

# slaves should implicitly activate, give them a chance to do so
if $is_slave; then
if ! timeout 5 bash -c "while ! nmcli -g GENERAL.STATE conn show "$conn" | grep activated; do sleep 1; done"; then
echo "WARNING: slave $conn did not implicitly activate in 5s, activating explicitly."
fi
fi

# Do not activate interfaces that are already active
# But set the entry in master_interfaces to true if this is a slave
# Also set autoconnect to yes
Expand Down