Skip to content

[release-4.19] OCPBUGS-62649: configure-ovs: work around a Cisco switch issue #5323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2025
Merged

[release-4.19] OCPBUGS-62649: configure-ovs: work around a Cisco switch issue #5323

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions templates/common/_base/files/configure-ovs-network.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,6 +561,16 @@ contents:
for conn in "${connections[@]}"; do
local slave_type=$(nmcli -g connection.slave-type connection show "$conn")
if [ "$slave_type" = "team" ] || [ "$slave_type" = "bond" ]; then
# Work around a Cisco switch issue: if a slave is detached from a bond
# (e.g. during NM reactivation) before LACP negotiation completes, the
# switch may mishandle LACP packets with agg=0. To avoid this, wait for
# LACP to finish (only applies to LACP bonds in state UP).
slave=$(nmcli -g connection.interface-name connection show "$conn")
if ip -d link show "$slave" | tr '\n' ' ' | grep -q 'state UP.*ad_aggregator_id'; then
if ! timeout 5 bash -c "while [ \$(ip -d link show \"$slave\" | grep -o \"collecting,distributing\" | wc -l) -lt 2 ]; do sleep 1; done"; then
echo "WARNING: LACP negotiation is not yet done on slave $conn."
fi
fi
mod_nm_conn "$conn" connection.autoconnect yes
fi
done
Expand Down