Skip to content

Conversation

sergiordlr
Copy link
Contributor

@sergiordlr sergiordlr commented Oct 14, 2025

- What I did
WIP

We hit this: openshift-eng/openshift-tests-extension#41

Summary

The test list was empty because the default ModuleTestsOnly() filter was excluding ALL tests that had any /vendor/ path in their code locations array. Since our MCO tests use compat_otp from the origin library, their code locations
include paths like:

/home/fedora/Workspace/machine-config-operator/vendor/github.com/openshift/origin/test/extended/util/client.go:183

Even though the PRIMARY code location was:
/home/fedora/Workspace/machine-config-operator/test/extended/mco_ocb.go:13

The standard ModuleTestsOnly() filter (which checks if ANY code location contains /vendor/) was filtering them out.

The Fix:
I implemented a custom filter in cmd/machine-config-tests-ext/main.go that only filters out tests where the FIRST (primary) code location is in the vendor directory. This allows our MCO tests, which are defined in test/extended/ but
call into compat_otp utilities, to be included in the test list.

- How to verify it

- Description for the changelog

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sergiordlr
Once this PR has been reviewed and has the lgtm label, please assign cheesesashimi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sergiordlr sergiordlr force-pushed the use_compat_otp_in_exetended_test_cases branch 4 times, most recently from 36a61b3 to f45d3cd Compare October 15, 2025 13:13
@sergiordlr sergiordlr force-pushed the use_compat_otp_in_exetended_test_cases branch from f45d3cd to c3ca88d Compare October 15, 2025 17:03
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 15, 2025

@sergiordlr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify c3ca88d link true /test verify
ci/prow/okd-scos-e2e-aws-ovn c3ca88d link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-hypershift c3ca88d link true /test e2e-hypershift
ci/prow/bootstrap-unit c3ca88d link false /test bootstrap-unit
ci/prow/e2e-aws-ovn c3ca88d link true /test e2e-aws-ovn
ci/prow/unit c3ca88d link true /test unit
ci/prow/e2e-gcp-op-1of2 c3ca88d link true /test e2e-gcp-op-1of2
ci/prow/e2e-aws-ovn-upgrade c3ca88d link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-gcp-op-single-node c3ca88d link true /test e2e-gcp-op-single-node
ci/prow/e2e-gcp-op-2of2 c3ca88d link true /test e2e-gcp-op-2of2
ci/prow/verify-deps c3ca88d link true /test verify-deps
ci/prow/images c3ca88d link true /test images
ci/prow/okd-scos-images c3ca88d link true /test okd-scos-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 18, 2025
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants