Skip to content

Conversation

mkowalski
Copy link
Contributor

Under specific scenario it is possible that between nodeip-configuration.service and kubelet.service the br-ex interface loses one of its IP stacks. This is undesired because it will cause kubelet to be stuck without any clear error message.

With this change we will make wait-for-node-ip.service fail in a clear way if one of the IP addresses used by kubelet are not available.

The timeout 60 seconds has been selected as arbitrary. In a positive scenario the service should succeed immediately. In a negative scenario when the IP address really disappeared, 60 seconds is fair to wait. In a scenario when we are racing and handle tentative IPv6 addresses 60 seconds is enough for an address to settle and become permanent.

Fixes: OCPBUGS-63152

Under specific scenario it is possible that between
nodeip-configuration.service and kubelet.service the br-ex interface
loses one of its IP stacks. This is undesired because it will cause
kubelet to be stuck without any clear error message.

With this change we will make wait-for-node-ip.service fail in a clear
way if one of the IP addresses used by kubelet are not available.

The timeout 60 seconds has been selected as arbitrary. In a positive
scenario the service should succeed immediately. In a negative scenario
when the IP address really disappeared, 60 seconds is fair to wait. In a
scenario when we are racing and handle tentative IPv6 addresses 60
seconds is enough for an address to settle and become permanent.
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 15, 2025
@openshift-ci-robot
Copy link
Contributor

@mkowalski: This pull request references Jira Issue OCPBUGS-63152, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Under specific scenario it is possible that between nodeip-configuration.service and kubelet.service the br-ex interface loses one of its IP stacks. This is undesired because it will cause kubelet to be stuck without any clear error message.

With this change we will make wait-for-node-ip.service fail in a clear way if one of the IP addresses used by kubelet are not available.

The timeout 60 seconds has been selected as arbitrary. In a positive scenario the service should succeed immediately. In a negative scenario when the IP address really disappeared, 60 seconds is fair to wait. In a scenario when we are racing and handle tentative IPv6 addresses 60 seconds is enough for an address to settle and become permanent.

Fixes: OCPBUGS-63152

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mkowalski
Once this PR has been reviewed and has the lgtm label, please assign yuqi-zhang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mkowalski
Copy link
Contributor Author

/jira refresh
/cc @cybertron

@openshift-ci openshift-ci bot requested a review from cybertron October 15, 2025 15:55
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 15, 2025
@openshift-ci-robot
Copy link
Contributor

@mkowalski: This pull request references Jira Issue OCPBUGS-63152, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @rbbratta

In response to this:

/jira refresh
/cc @cybertron

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from rbbratta October 15, 2025 15:56
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 15, 2025

@mkowalski: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-op-single-node 34cab0e link true /test e2e-gcp-op-single-node
ci/prow/okd-scos-e2e-aws-ovn 34cab0e link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-hypershift 34cab0e link true /test e2e-hypershift
ci/prow/e2e-gcp-op-2of2 34cab0e link true /test e2e-gcp-op-2of2
ci/prow/e2e-gcp-op-1of2 34cab0e link true /test e2e-gcp-op-1of2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants