MCO-1714: MCO-1715: MCO-1716: Add 3 regression tests for ImageModeStatusReporting FeatureGate #5363

isabella-janssen · 2025-10-17T18:54:37Z

- What I did
This adds three regression tests for the ImageModeStatusReporting feature gate.

MCO-1716: MachineConfigNode properties should match the associated node properties when OCB is enabled in a custom MCP
- This test checks that the new image mode status reporting fields, namely the desired and current config image values, are set when on-cluster image mode is enabled in a custom MCP.
MCO-1715: MachineConfigNode conditions should properly transition on an image based update when OCB is enabled in a custom MCP
- This test checks that all MCN conditions, including the ImagePulledFromRegistry condition added for image mode status reporting, transition as expected when an update requiring a new image to build (as defined in MCO-1580: MCO-1581: Achieving parity with MCO node disruption frequency #4996) is triggered in a custom MCP with on-cluster image mode enabled.
MCO-1714: MachineConfigNode conditions should properly transition on a non-image based update when OCB is enabled in a custom MCP
- This test checks that all MCN conditions transition as expected when an update not requiring a new image to build (as defined in MCO-1580: MCO-1581: Achieving parity with MCO node disruption frequency #4996) is triggered in a custom MCP with on-cluster image mode enabled.

- How to verify it
To test locally:

$ make all
$ <path_to_machine-config-tests-ext> run-test "[sig-mco][Suite:openshift/machine-config-operator/disruptive][Serial][Disruptive][OCPFeatureGate:ImageModeStatusReporting] MachineConfigNode properties should match the associated node properties when OCB is enabled in a custom MCP [apigroup:machineconfiguration.openshift.io]"
$ <path_to_machine-config-tests-ext> run-test "[sig-mco][Suite:openshift/machine-config-operator/disruptive][Serial][Disruptive][OCPFeatureGate:ImageModeStatusReporting] MachineConfigNode conditions should properly transition on an image based update when OCB is enabled in a custom MCP [apigroup:machineconfiguration.openshift.io]"
$ <path_to_machine-config-tests-ext> run-test "[sig-mco][Suite:openshift/machine-config-operator/disruptive][Serial][Disruptive][OCPFeatureGate:ImageModeStatusReporting] MachineConfigNode conditions should properly transition on a non-image based update when OCB is enabled in a custom MCP [apigroup:machineconfiguration.openshift.io]"

To test in a payload rehersal:
Check the results of the tech preview MCO disruptive suite runs:

periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-vsphere-mco-disruptive-techpreview
periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv4-mco-disruptive-techpreview
periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv6-mco-disruptive-techpreview
periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-dualstack-mco-disruptive-techpreview
periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview
periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview
periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-azure-mco-disruptive-techpreview

- Description for the changelog
MCO-1714: MCO-1715: MCO-1716: Add 3 regression tests for ImageModeStatusReporting FeatureGate

openshift-ci · 2025-10-17T18:54:47Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci · 2025-10-17T18:55:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isabella-janssen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [isabella-janssen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

isabella-janssen · 2025-10-17T19:00:43Z

/payload-job periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview

openshift-ci · 2025-10-17T19:00:49Z

@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/95168410-ab8b-11f0-8431-c8fef12fe441-0

isabella-janssen · 2025-10-20T15:07:49Z

/payload-job periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview

openshift-ci · 2025-10-20T15:07:54Z

@isabella-janssen: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview
periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8beb0310-adc6-11f0-8fcf-26f95e5d952e-0

isabella-janssen · 2025-10-21T14:14:19Z

/payload-job periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview

openshift-ci · 2025-10-21T14:14:32Z

@isabella-janssen: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview
periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3c3be970-ae88-11f0-9906-629cd38ec285-0

openshift-ci-robot · 2025-10-22T18:17:56Z

@isabella-janssen: This pull request references MCO-1714 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

- What I did
This adds three regression tests for the ImageModeStatusReporting feature gate.

- How to verify it

MCO-XXXX: MachineConfigNode properties should match the associated node properties when OCB is enabled in a custom MCP

This test checks that the new image mode status reporting fields, namely the desired and current config image values, are set when on-cluster image mode is enabled in a custom MCP.

MCO-1715: MachineConfigNode conditions should properly transition on an image based update when OCB is enabled in a custom MCP

This test checks that all MCN conditions, including the ImagePulledFromRegistry condition added for image mode status reporting, transition as expected when an update requiring a new image to build (as defined in MCO-1580: MCO-1581: Achieving parity with MCO node disruption frequency #4996) is triggered in a custom MCP with on-cluster image mode enabled.

MCO-1714: MachineConfigNode conditions should properly transition on a non-image based update when OCB is enabled in a custom MCP

This test checks that all MCN conditions transition as expected when an update not requiring a new image to build (as defined in MCO-1580: MCO-1581: Achieving parity with MCO node disruption frequency #4996) is triggered in a custom MCP with on-cluster image mode enabled.

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-10-22T18:18:48Z

@isabella-janssen: This pull request references MCO-1714 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

- What I did
This adds three regression tests for the ImageModeStatusReporting feature gate.

- How to verify it

MCO-XXXX: MachineConfigNode properties should match the associated node properties when OCB is enabled in a custom MCP

This test checks that the new image mode status reporting fields, namely the desired and current config image values, are set when on-cluster image mode is enabled in a custom MCP.

MCO-1715: MachineConfigNode conditions should properly transition on an image based update when OCB is enabled in a custom MCP

This test checks that all MCN conditions, including the ImagePulledFromRegistry condition added for image mode status reporting, transition as expected when an update requiring a new image to build (as defined in MCO-1580: MCO-1581: Achieving parity with MCO node disruption frequency #4996) is triggered in a custom MCP with on-cluster image mode enabled.

MCO-1714: MachineConfigNode conditions should properly transition on a non-image based update when OCB is enabled in a custom MCP

This test checks that all MCN conditions transition as expected when an update not requiring a new image to build (as defined in MCO-1580: MCO-1581: Achieving parity with MCO node disruption frequency #4996) is triggered in a custom MCP with on-cluster image mode enabled.

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-10-22T19:45:36Z

@isabella-janssen: This pull request references MCO-1714 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

- What I did
This adds three regression tests for the ImageModeStatusReporting feature gate.

MCO-1716: MachineConfigNode properties should match the associated node properties when OCB is enabled in a custom MCP

This test checks that the new image mode status reporting fields, namely the desired and current config image values, are set when on-cluster image mode is enabled in a custom MCP.

MCO-1715: MachineConfigNode conditions should properly transition on an image based update when OCB is enabled in a custom MCP

This test checks that all MCN conditions, including the ImagePulledFromRegistry condition added for image mode status reporting, transition as expected when an update requiring a new image to build (as defined in MCO-1580: MCO-1581: Achieving parity with MCO node disruption frequency #4996) is triggered in a custom MCP with on-cluster image mode enabled.

MCO-1714: MachineConfigNode conditions should properly transition on a non-image based update when OCB is enabled in a custom MCP

This test checks that all MCN conditions transition as expected when an update not requiring a new image to build (as defined in MCO-1580: MCO-1581: Achieving parity with MCO node disruption frequency #4996) is triggered in a custom MCP with on-cluster image mode enabled.

- How to verify it
To test locally:
$ make all
$ <path_to_machine-config-tests-ext> run-test "[sig-mco][Suite:openshift/machine-config-operator/disruptive][Serial][Disruptive][OCPFeatureGate:ImageModeStatusReporting] MachineConfigNode properties should match the associated node properties when OCB is enabled in a custom MCP [apigroup:machineconfiguration.openshift.io]"
$ <path_to_machine-config-tests-ext> run-test "[sig-mco][Suite:openshift/machine-config-operator/disruptive][Serial][Disruptive][OCPFeatureGate:ImageModeStatusReporting] MachineConfigNode conditions should properly transition on an image based update when OCB is enabled in a custom MCP [apigroup:machineconfiguration.openshift.io]"
$ <path_to_machine-config-tests-ext> run-test "[sig-mco][Suite:openshift/machine-config-operator/disruptive][Serial][Disruptive][OCPFeatureGate:ImageModeStatusReporting] MachineConfigNode conditions should properly transition on a non-image based update when OCB is enabled in a custom MCP [apigroup:machineconfiguration.openshift.io]"
To test in a payload rehersal:
Check the results of the tech preview MCO disruptive suite runs:

periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-vsphere-mco-disruptive-techpreview

periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv4-mco-disruptive-techpreview

periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv6-mco-disruptive-techpreview

periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-dualstack-mco-disruptive-techpreview

periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview

periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview

periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-azure-mco-disruptive-techpreview

- Description for the changelog
MCO-1714: MCO-1715: MCO-1716: Add 3 regression tests for ImageModeStatusReporting FeatureGate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-10-22T19:45:42Z

@isabella-janssen: This pull request references MCO-1714 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

- What I did
This adds three regression tests for the ImageModeStatusReporting feature gate.

MCO-1716: MachineConfigNode properties should match the associated node properties when OCB is enabled in a custom MCP

This test checks that the new image mode status reporting fields, namely the desired and current config image values, are set when on-cluster image mode is enabled in a custom MCP.

MCO-1715: MachineConfigNode conditions should properly transition on an image based update when OCB is enabled in a custom MCP

This test checks that all MCN conditions, including the ImagePulledFromRegistry condition added for image mode status reporting, transition as expected when an update requiring a new image to build (as defined in MCO-1580: MCO-1581: Achieving parity with MCO node disruption frequency #4996) is triggered in a custom MCP with on-cluster image mode enabled.

MCO-1714: MachineConfigNode conditions should properly transition on a non-image based update when OCB is enabled in a custom MCP

This test checks that all MCN conditions transition as expected when an update not requiring a new image to build (as defined in MCO-1580: MCO-1581: Achieving parity with MCO node disruption frequency #4996) is triggered in a custom MCP with on-cluster image mode enabled.

- How to verify it
To test locally:
$ make all
$ <path_to_machine-config-tests-ext> run-test "[sig-mco][Suite:openshift/machine-config-operator/disruptive][Serial][Disruptive][OCPFeatureGate:ImageModeStatusReporting] MachineConfigNode properties should match the associated node properties when OCB is enabled in a custom MCP [apigroup:machineconfiguration.openshift.io]"
$ <path_to_machine-config-tests-ext> run-test "[sig-mco][Suite:openshift/machine-config-operator/disruptive][Serial][Disruptive][OCPFeatureGate:ImageModeStatusReporting] MachineConfigNode conditions should properly transition on an image based update when OCB is enabled in a custom MCP [apigroup:machineconfiguration.openshift.io]"
$ <path_to_machine-config-tests-ext> run-test "[sig-mco][Suite:openshift/machine-config-operator/disruptive][Serial][Disruptive][OCPFeatureGate:ImageModeStatusReporting] MachineConfigNode conditions should properly transition on a non-image based update when OCB is enabled in a custom MCP [apigroup:machineconfiguration.openshift.io]"
To test in a payload rehersal:
Check the results of the tech preview MCO disruptive suite runs:

periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-vsphere-mco-disruptive-techpreview

periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv4-mco-disruptive-techpreview

periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv6-mco-disruptive-techpreview

periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-dualstack-mco-disruptive-techpreview

periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview

periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview

periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-azure-mco-disruptive-techpreview

- Description for the changelog
MCO-1714: MCO-1715: MCO-1716: Add 3 regression tests for ImageModeStatusReporting FeatureGate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

isabella-janssen · 2025-10-22T21:31:26Z

/payload-job periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview

openshift-ci · 2025-10-22T21:31:31Z

@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/77c85580-af8e-11f0-9627-820b17069e7e-0

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2025

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2025

test/extended: add image mode status reporting tests

06d0c2b

isabella-janssen force-pushed the mco-1714 branch from 295cca0 to 06d0c2b Compare October 17, 2025 18:55

isabella-janssen mentioned this pull request Oct 17, 2025

(WIP) <ticket-id>: Add regression tests for image mode status reporting in MCN on OCL updates #5344

Closed

initial thoughts for MCN transition on image update

8173339

isabella-janssen added 3 commits October 21, 2025 11:37

skeleton for mcn transition on non-image update

d9194e4

updates

91e35c9

fix MC templates

367e044

isabella-janssen changed the title ~~(WIP) <ticket-id>: Add regression tests for image mode status reporting in MCN resource~~ MCO-1714: MCO-1715: MCO-XXXX: Add regression tests for image mode status reporting in MCN resource Oct 22, 2025

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 22, 2025

isabella-janssen changed the title ~~MCO-1714: MCO-1715: MCO-XXXX: Add regression tests for image mode status reporting in MCN resource~~ MCO-1714: MCO-1715: MCO-XXXX: Add 3/5 regression tests for image mode status reporting in MCN resource Oct 22, 2025

isabella-janssen changed the title ~~MCO-1714: MCO-1715: MCO-XXXX: Add 3/5 regression tests for image mode status reporting in MCN resource~~ MCO-1714: MCO-1715: MCO-XXXX: Add 3/5 regression tests for ImageModeStatusReporting FeatureGate Oct 22, 2025

isabella-janssen changed the title ~~MCO-1714: MCO-1715: MCO-XXXX: Add 3/5 regression tests for ImageModeStatusReporting FeatureGate~~ MCO-1714: MCO-1715: MCO-1716: Add 3/5 regression tests for ImageModeStatusReporting FeatureGate Oct 22, 2025

isabella-janssen changed the title ~~MCO-1714: MCO-1715: MCO-1716: Add 3/5 regression tests for ImageModeStatusReporting FeatureGate~~ MCO-1714: MCO-1715: MCO-1716: Add 3 regression tests for ImageModeStatusReporting FeatureGate Oct 22, 2025

working

16f5c23

MCO-1714: MCO-1715: MCO-1716: Add 3 regression tests for ImageModeStatusReporting FeatureGate #5363

Are you sure you want to change the base?

MCO-1714: MCO-1715: MCO-1716: Add 3 regression tests for ImageModeStatusReporting FeatureGate #5363

Uh oh!

Conversation

isabella-janssen commented Oct 17, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Oct 17, 2025

Uh oh!

openshift-ci bot commented Oct 17, 2025

Uh oh!

isabella-janssen commented Oct 17, 2025

Uh oh!

openshift-ci bot commented Oct 17, 2025

Uh oh!

isabella-janssen commented Oct 20, 2025

Uh oh!

openshift-ci bot commented Oct 20, 2025

Uh oh!

isabella-janssen commented Oct 21, 2025

Uh oh!

openshift-ci bot commented Oct 21, 2025

Uh oh!

openshift-ci-robot commented Oct 22, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Oct 22, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Oct 22, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Oct 22, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

isabella-janssen commented Oct 22, 2025

Uh oh!

openshift-ci bot commented Oct 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

isabella-janssen commented Oct 17, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 22, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 22, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 22, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 22, 2025 •

edited by openshift-ci bot

Loading