-
Notifications
You must be signed in to change notification settings - Fork 450
MCO-1930: Add Component Readiness tests for CPMS boot image updates #5369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
@djoshy: This pull request references MCO-1930 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: djoshy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/payload-job periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-azure-mco-disruptive-techpreview |
@djoshy: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b16822a0-aeb9-11f0-9274-c273f7924613-0 |
8afa685
to
82dbc48
Compare
@djoshy: This pull request references MCO-1930 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/payload-job periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-azure-mco-disruptive-techpreview /verified bypass |
@djoshy: The In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@djoshy: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f11d0650-af49-11f0-8392-3a174395e733-0 |
@djoshy: This pull request references MCO-1930 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@djoshy: This pull request references MCO-1930 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@djoshy: This pull request references MCO-1930 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This PR adds 6 CR tests(2 per platform for AWS, GCP and Azure) for CPMS boot image updates to the MCO's extended test suite.
The first test verifies the "All" mode for
ControlPlaneMachineSets
. As the CPMS resource is a singleton, this mode effectively enables control plane boot image updates for the whole cluster. The test then checks that an update takes place by backdating the boot image and examining the CPMS resource. If the MCO has updated it correctly, the test then proceeds to verify the scale-up process by deleting an existing control plane machine. This last step can take a while as while a new node does scale-up and join the cluster quickly, the CPMS operator only proceeds to scale-down the old node after that. I think this is to maintain etcd quorum. Draining and deleting the old control plane node at the end of the test takes a while - the whole test seemed to vary between 15-20 minutes depending on the platform.The second test verifies "None" mode for
ControlPlaneMachinesets
. This test is a lot more simpler than the first; it just checks if the backdated boot image does get updated by the MCO. The test is considered successful if the backdated boot image is left untouched.This PR should not need QE verification since it is not affecting any functions of the MCO, it only adds new tests.