[release-4.20] OCPBUGS-70349: Remove the dead code of setting the operator status for cgroupv1 based clusters #5446
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@sairameshv: This pull request references OCPNODE-3883 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.20." or "openshift-4.20.", but it targets "openshift-4.21" instead. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@sairameshv: This pull request references OCPNODE-3883 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.20." or "openshift-4.20.", but it targets "openshift-4.21" instead. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
isabella-janssen
left a comment
isabella-janssen
left a comment
There was a problem hiding this comment.
/approve
/label backport-risk-assessed
This looks like a fair change to me as the OCP docs do indicate that a cluster with cgroup v1 cannot upgrade to 4.19, which makes the removed block of code unnecessary, and is a clean backport.
openshift-ci
bot
added
the
backport-risk-assessed
openshift-ci
bot
assigned
anuragthehatter,
eurijon,
imatza-rh,
lyman9966,
mhanss,
ptalgulk01,
rbbratta,
rioliu-rh,
sergiordlr and
zhaozhanqi
openshift-ci
bot
added
the
approved
|
/lgtm |
openshift-merge-robot
added
the
needs-rebase
clusters - Option of configuring cgroupv1 has been removed in OCP - 4.19 - It is safe to remove this check from the operator status for all the clusters greater than OCP - 4.19 - Also removed the cluster fleet evaluation that checks if a cluster is configured with cgroupv1 Signed-off-by: Sai Ramesh Vanka <[email protected]>
sairameshv
force-pushed
the
remove_cgrpv1_4.20
branch
from
536f1f7 to
704f74a
Compare
openshift-merge-robot
removed
the
needs-rebase
sairameshv
changed the title
|
@sairameshv: This pull request references Jira Issue OCPBUGS-70349, which is valid. 7 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: isabella-janssen, QiWang19, sairameshv The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified by @sairameshv |
openshift-ci-robot
added
the
verified
|
@sairameshv: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@sairameshv: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit bf69ce3
into
openshift:release-4.20
|
@sairameshv: Jira Issue OCPBUGS-70349: Some pull requests linked via external trackers have merged: The following pull request, linked via external tracker, has not merged: All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-70349 has not been moved to the MODIFIED state. This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
15 participants
Manual backport of #5399