[release-4.18] OCPBUGS-71227: MCP is not correctly degraded when a pivotError happens

[dkhater-redhat]

- What I did
Why Both Functions Need the Fix in 4.18

In 4.18, the code has two separate code paths:

• update() - handles regular non-OCL updates
• updateOnClusterBuild() - handles OCL (On-Cluster Layering) updates
  - How to verify it

- Description for the changelog

[openshift-ci-robot]

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-71227, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

- What I did
Why Both Functions Need the Fix in 4.18

In 4.18, the code has two separate code paths:

• update() - handles regular non-OCL updates
• updateOnClusterBuild() - handles OCL (On-Cluster Layering) updates
  - How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkhater-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dkhater-redhat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sergiordlr]

This is what we see with this fix

E0115 09:45:00.361780    2637 writer.go:231] Marking Degraded due to: "Failed to update OS to quay.io/openshifttest/hello-openshift:1.2.0 after retries: timed out waiting for the condition"
I0115 09:45:00.374181    2637 daemon.go:743] Transitioned from state: Done -> Working
E0115 09:46:34.022690    2637 writer.go:231] Marking Degraded due to: "Failed to update OS to quay.io/openshifttest/hello-openshift:1.2.0 after retries: timed out waiting for the condition"
I0115 09:46:34.022908    2637 daemon.go:743] Transitioned from state: Working -> Degraded
I0115 09:46:34.022922    2637 daemon.go:746] Transitioned from degraded/unreconcilable reason  -> Failed to update OS to quay.io/openshifttest/hello-openshift:1.2.0 after retries: timed out waiting for the condition
[fedora@preserve-sregidor-work ~]$ nodelogs ip-10-0-0-19.us-east-2.compute.internal  | grep  -P "Degraded|Transition"
E0115 09:45:00.361780    2637 writer.go:231] Marking Degraded due to: "Failed to update OS to quay.io/openshifttest/hello-openshift:1.2.0 after retries: timed out waiting for the condition"
I0115 09:45:00.374181    2637 daemon.go:743] Transitioned from state: Done -> Working
E0115 09:46:34.022690    2637 writer.go:231] Marking Degraded due to: "Failed to update OS to quay.io/openshifttest/hello-openshift:1.2.0 after retries: timed out waiting for the condition"
I0115 09:46:34.022908    2637 daemon.go:743] Transitioned from state: Working -> Degraded
I0115 09:46:34.022922    2637 daemon.go:746] Transitioned from degraded/unreconcilable reason  -> Failed to update OS to quay.io/openshifttest/hello-openshift:1.2.0 after retries: timed out waiting for the condition
E0115 09:48:08.788405    2637 writer.go:231] Marking Degraded due to: "Failed to update OS to quay.io/openshifttest/hello-openshift:1.2.0 after retries: timed out waiting for the condition"
E0115 09:49:42.593623    2637 writer.go:231] Marking Degraded due to: "Failed to update OS to quay.io/openshifttest/hello-openshift:1.2.0 after retries: timed out waiting for the condition

Instead of setting the Degraded state, it goes to Working state, and then to Degraded state later. It should set the Degraded state directly.

[openshift-ci]

@dkhater-redhat: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/unit	63e080a	link	true	/test unit
ci/prow/bootstrap-unit	63e080a	link	false	/test bootstrap-unit
ci/prow/e2e-hypershift	63e080a	link	true	/test e2e-hypershift

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-merge-robot]

Fix included in accepted release 4.18.0-0.nightly-2026-01-19-214631