MCO-2055 migrate bootimages tests #5551
Conversation
|
/payload-job periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-tp-longduration periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-aws-mco-fips-proxy-longduration |
|
@sergiordlr: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9f5f26a0-f156-11f0-84a5-8dfeb1e48657-0 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sergiordlr The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
sergiordlr
force-pushed
the
mco_2055_migrate_bootimages_tests
branch
from
1a59954 to
4a57371
Compare
|
/payload-job periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-tp-longduration periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-aws-mco-fips-proxy-longduration |
|
@sergiordlr: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1dc2e590-f1fc-11f0-8f77-5f080a0710c7-0 |
sergiordlr
force-pushed
the
mco_2055_migrate_bootimages_tests
branch
from
4a57371 to
93364f1
Compare
|
/payload-job periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-tp-longduration periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-aws-mco-fips-proxy-longduration |
|
@sergiordlr: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c4add010-f231-11f0-902f-78b2365c85ad-0 |
|
The payload executions have a 6 hours hardcoded timeout. We manually trigger the executions so that the execution can properly finish. Manually triggered executions: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-tp-longduration/2011863991181119488 |
sergiordlr
force-pushed
the
mco_2055_migrate_bootimages_tests
branch
from
93364f1 to
cd71c63
Compare
|
/payload-job periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-tp-longduration periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-aws-mco-fips-proxy-longduration |
|
@sergiordlr: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/dca64460-f243-11f0-8246-3e608d3f36ad-0 |
|
/test e2e-gcp-op-single-node |
|
/test e2e-gcp-op-2of2 |
test/extended-priv/util/vsphere.go
Outdated
| // Build vSphere URL | ||
| u, err := url.Parse(fmt.Sprintf("https://%s:%s@%s/sdk", user, password, server)) | ||
| if err != nil { | ||
| return "", fmt.Errorf("failed to parse vSphere URL: %w", err) |
There was a problem hiding this comment.
I hope the error doesn't contain the password. I'd be more comfortable getting rid of the error in the error message.
There was a problem hiding this comment.
We have changed the way we provide the credentials
| } | ||
|
|
||
| // PrettyString returns an indented json string with the definition of the resource | ||
| func (r ocGetter) PrettyString() string { |
There was a problem hiding this comment.
Uhmmm this one can be dangerous, what happens if we call it on a resource that has sensitive content like the pull-secret?
There was a problem hiding this comment.
Actually, the function itself is not dangerous since it doesn't print anything. What's dangerous is printing the return value of this function.
sergiordlr
force-pushed
the
mco_2055_migrate_bootimages_tests
branch
from
cd71c63 to
3533ab5
Compare
|
@sergiordlr: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/payload-job periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-tp-longduration |
|
@sergiordlr: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/35cd8d00-f2f8-11f0-82c5-7e5ca235accd-0 |
2 participants
- What I did
Migrate the boot image update tests in mco_bootimage.go from the private repository to the MCO repository.
The test cases have been added to the longduration suite.
- How to verify it
All tests should pass