-
Notifications
You must be signed in to change notification settings - Fork 34
OU-1031: Show the alert request error to the user #607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@PeterYurkovich: This pull request references OU-1031 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PeterYurkovich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label qe-approved |
@PeterYurkovich: This pull request references OU-1031 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/label ux-approved |
/retest |
2 similar comments
/retest |
/retest |
@PeterYurkovich: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Previously requests being denied to the user were confusing and just had "forbidden" written out. This fact, in combination with pages that showed multiple errors that overlapped, led to a confusing set of pages when the user didn't have access to see anything. We have now included the error value in the screen and reduced noise on the alert and alertmanager pages.
Before



After


