Skip to content

Conversation

PeterYurkovich
Copy link
Contributor

Previously requests being denied to the user were confusing and just had "forbidden" written out. This fact, in combination with pages that showed multiple errors that overlapped, led to a confusing set of pages when the user didn't have access to see anything. We have now included the error value in the screen and reduced noise on the alert and alertmanager pages.

Before
Screenshot From 2025-10-17 11-50-51
Screenshot From 2025-10-17 11-50-56
Screenshot From 2025-10-17 11-50-59

After
Screenshot From 2025-10-17 11-49-22
Screenshot From 2025-10-17 11-49-27
Screenshot From 2025-10-17 11-49-31

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 17, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 17, 2025

@PeterYurkovich: This pull request references OU-1031 which is a valid jira issue.

In response to this:

Previously requests being denied to the user were confusing and just had "forbidden" written out. This fact, in combination with pages that showed multiple errors that overlapped, led to a confusing set of pages when the user didn't have access to see anything. We have now included the error value in the screen and reduced noise on the alert and alertmanager pages.

Before
Screenshot From 2025-10-17 11-50-51
Screenshot From 2025-10-17 11-50-56
Screenshot From 2025-10-17 11-50-59

After
Screenshot From 2025-10-17 11-49-22
Screenshot From 2025-10-17 11-49-27
Screenshot From 2025-10-17 11-49-31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from etmurasaki and kyoto October 17, 2025 15:55
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2025
@etmurasaki
Copy link
Contributor

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 17, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 17, 2025

@PeterYurkovich: This pull request references OU-1031 which is a valid jira issue.

In response to this:

Previously requests being denied to the user were confusing and just had "forbidden" written out. This fact, in combination with pages that showed multiple errors that overlapped, led to a confusing set of pages when the user didn't have access to see anything. We have now included the error value in the screen and reduced noise on the alert and alertmanager pages.

Before
Screenshot From 2025-10-17 11-50-51
Screenshot From 2025-10-17 11-50-56
Screenshot From 2025-10-17 11-50-59

After
Screenshot From 2025-10-17 11-49-22
Screenshot From 2025-10-17 11-49-27
Screenshot From 2025-10-17 11-49-31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@fkargbo
Copy link

fkargbo commented Oct 19, 2025

/label ux-approved

@openshift-ci openshift-ci bot added the ux-approved Signifies that UX has signed off on this PR label Oct 19, 2025
@jgbernalp
Copy link
Contributor

/retest

2 similar comments
@etmurasaki
Copy link
Contributor

/retest

@PeterYurkovich
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2025

@PeterYurkovich: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn e3d917d link true /test e2e-aws-ovn
ci/prow/okd-scos-e2e-aws-ovn e3d917d link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. qe-approved Signifies that QE has signed off on this PR ux-approved Signifies that UX has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants