-
Notifications
You must be signed in to change notification settings - Fork 34
OBSINTA-777: [Incidents] Regression for Charts Display #609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
OBSINTA-777: [Incidents] Regression for Charts Display #609
Conversation
- Add test for initial incidents loading without filter manipulation (OU-1002) - Add parameterized tests for dropdown closure on deselection (OU-1033) * Tests 3 dropdown types (filter type, severity, days) * Tests 2 deselection methods (bar click, chip removal) - Add test for incident ID filter preservation (OU-1030)
- Add test for initial incidents loading without filter manipulation (OU-1002) - Add parameterized tests for dropdown closure on deselection (OU-1033) * Tests 3 dropdown types (filter type, severity, days) * Tests 2 deselection methods (bar click, chip removal) - Add test for incident ID filter preservation (OU-1030)
Add comprehensive regression tests for tooltip positioning, bar sorting, and date/time display in incidents charts. - 3 consolidated test sections covering various scenarios - Page object enhancements for alert chart interactions - Victory chart tooltip positioning with 12px arrow + 8px margin validation Verifies Section 2 of TESTING_CHECKLIST.md
@DavidRajnoha: This pull request references OBSINTA-777 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: DavidRajnoha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label qe-approved |
/label ux-approved |
@DavidRajnoha: This pull request references OBSINTA-777 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
@DavidRajnoha: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Charts UI Regression Test Coverage
This PR adds regression tests for the Charts UI components on the Incidents page.
The PR is already rebased on #606
I. Tooltip Integrity
The tests ensure tooltips are correctly positioned and provide accurate incident details across various data conditions.
Positioning (Section 2.1)
Content (Section 2.1)
---
for the end time.II. Chart Bar Rendering and Logic
This section confirms accurate chronological sorting, bar visibility, and functional filtering behavior.
Sorting (Section 2.2)
Visibility (Section 2.2)
Filtering (Section 2.2)
III. Time and Severity Visualization
The tests validate the accurate presentation of time formats and the visualization of severity changes.
Date/Time Display (Section 2.3)
Multi-Severity (Section 2.3)