Skip to content

Conversation

DavidRajnoha
Copy link
Contributor

Charts UI Regression Test Coverage

This PR adds regression tests for the Charts UI components on the Incidents page.

The PR is already rebased on #606

I. Tooltip Integrity

The tests ensure tooltips are correctly positioned and provide accurate incident details across various data conditions.

Positioning (Section 2.1)

  • Viewport Containment: All tooltips (Incident and Alert charts) remain entirely within the visible viewport.
  • Vertical Placement: Tooltips consistently render above the associated bar without any overlap.
  • Edge Case Validation: Verifies correct positioning for the topmost (newest) and bottommost (oldest) incidents.

Content (Section 2.1)

  • Firing Status: Tooltips for firing incidents correctly display the placeholder --- for the end time.
  • Resolved Status: Tooltips for resolved incidents display accurate Start and End timestamps.
  • Complexity Handling:
    • Multi-Component: Tooltips correctly list all components involved in the incident.
    • Long Names: Tooltips for incidents with very long alert names (180+ characters) are validated to wrap correctly and maintain viewport containment.

II. Chart Bar Rendering and Logic

This section confirms accurate chronological sorting, bar visibility, and functional filtering behavior.

Sorting (Section 2.2)

  • Chronological Order: Incidents are correctly sorted, with the newest incident at the top (index 0) and the oldest at the bottom.

Visibility (Section 2.2)

  • Short Duration: Incidents with minimal durations (e.g., 10 minutes) are guaranteed to render with a visible width and height greater than zero.
  • Opacity: Short-duration bars are confirmed to be visible, not rendered transparently.

Filtering (Section 2.2)

  • Y-Axis Spacing: When filters (e.g., severity) are applied, the remaining visible bars maintain their correct vertical spacing (Y-axis positions).

III. Time and Severity Visualization

The tests validate the accurate presentation of time formats and the visualization of severity changes.

Date/Time Display (Section 2.3)

  • Formatted Times: All timestamps in tooltips and the expanded Alerts Table use the correct, formatted local time.
  • Table Status: Start and end times for individual alerts in the Alerts Table accurately reflect their status (timestamp or placeholder text for firing).

Multi-Severity (Section 2.3)

  • Segment Rendering: Incident bars that progressed through multiple severities are verified to display the corresponding multiple colored segments.

- Add test for initial incidents loading without filter manipulation (OU-1002)
- Add parameterized tests for dropdown closure on deselection (OU-1033)
  * Tests 3 dropdown types (filter type, severity, days)
  * Tests 2 deselection methods (bar click, chip removal)
- Add test for incident ID filter preservation (OU-1030)
- Add test for initial incidents loading without filter manipulation (OU-1002)
- Add parameterized tests for dropdown closure on deselection (OU-1033)
  * Tests 3 dropdown types (filter type, severity, days)
  * Tests 2 deselection methods (bar click, chip removal)
- Add test for incident ID filter preservation (OU-1030)
Add comprehensive regression tests for tooltip positioning, bar sorting,
and date/time display in incidents charts.

- 3 consolidated test sections covering  various scenarios
- Page object enhancements for alert chart interactions
- Victory chart tooltip positioning with 12px arrow + 8px margin validation

Verifies Section 2 of TESTING_CHECKLIST.md
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 20, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 20, 2025

@DavidRajnoha: This pull request references OBSINTA-777 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Charts UI Regression Test Coverage

This PR adds regression tests for the Charts UI components on the Incidents page.

The PR is already rebased on #606

I. Tooltip Integrity

The tests ensure tooltips are correctly positioned and provide accurate incident details across various data conditions.

Positioning (Section 2.1)

  • Viewport Containment: All tooltips (Incident and Alert charts) remain entirely within the visible viewport.
  • Vertical Placement: Tooltips consistently render above the associated bar without any overlap.
  • Edge Case Validation: Verifies correct positioning for the topmost (newest) and bottommost (oldest) incidents.

Content (Section 2.1)

  • Firing Status: Tooltips for firing incidents correctly display the placeholder --- for the end time.
  • Resolved Status: Tooltips for resolved incidents display accurate Start and End timestamps.
  • Complexity Handling:
    • Multi-Component: Tooltips correctly list all components involved in the incident.
    • Long Names: Tooltips for incidents with very long alert names (180+ characters) are validated to wrap correctly and maintain viewport containment.

II. Chart Bar Rendering and Logic

This section confirms accurate chronological sorting, bar visibility, and functional filtering behavior.

Sorting (Section 2.2)

  • Chronological Order: Incidents are correctly sorted, with the newest incident at the top (index 0) and the oldest at the bottom.

Visibility (Section 2.2)

  • Short Duration: Incidents with minimal durations (e.g., 10 minutes) are guaranteed to render with a visible width and height greater than zero.
  • Opacity: Short-duration bars are confirmed to be visible, not rendered transparently.

Filtering (Section 2.2)

  • Y-Axis Spacing: When filters (e.g., severity) are applied, the remaining visible bars maintain their correct vertical spacing (Y-axis positions).

III. Time and Severity Visualization

The tests validate the accurate presentation of time formats and the visualization of severity changes.

Date/Time Display (Section 2.3)

  • Formatted Times: All timestamps in tooltips and the expanded Alerts Table use the correct, formatted local time.
  • Table Status: Start and end times for individual alerts in the Alerts Table accurately reflect their status (timestamp or placeholder text for firing).

Multi-Severity (Section 2.3)

  • Segment Rendering: Incident bars that progressed through multiple severities are verified to display the corresponding multiple colored segments.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jgbernalp and kyoto October 20, 2025 12:50
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DavidRajnoha
Once this PR has been reviewed and has the lgtm label, please assign kyoto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@falox
Copy link
Contributor

falox commented Oct 22, 2025

/label qe-approved

@falox
Copy link
Contributor

falox commented Oct 22, 2025

/label ux-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 22, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 22, 2025

@DavidRajnoha: This pull request references OBSINTA-777 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Charts UI Regression Test Coverage

This PR adds regression tests for the Charts UI components on the Incidents page.

The PR is already rebased on #606

I. Tooltip Integrity

The tests ensure tooltips are correctly positioned and provide accurate incident details across various data conditions.

Positioning (Section 2.1)

  • Viewport Containment: All tooltips (Incident and Alert charts) remain entirely within the visible viewport.
  • Vertical Placement: Tooltips consistently render above the associated bar without any overlap.
  • Edge Case Validation: Verifies correct positioning for the topmost (newest) and bottommost (oldest) incidents.

Content (Section 2.1)

  • Firing Status: Tooltips for firing incidents correctly display the placeholder --- for the end time.
  • Resolved Status: Tooltips for resolved incidents display accurate Start and End timestamps.
  • Complexity Handling:
    • Multi-Component: Tooltips correctly list all components involved in the incident.
    • Long Names: Tooltips for incidents with very long alert names (180+ characters) are validated to wrap correctly and maintain viewport containment.

II. Chart Bar Rendering and Logic

This section confirms accurate chronological sorting, bar visibility, and functional filtering behavior.

Sorting (Section 2.2)

  • Chronological Order: Incidents are correctly sorted, with the newest incident at the top (index 0) and the oldest at the bottom.

Visibility (Section 2.2)

  • Short Duration: Incidents with minimal durations (e.g., 10 minutes) are guaranteed to render with a visible width and height greater than zero.
  • Opacity: Short-duration bars are confirmed to be visible, not rendered transparently.

Filtering (Section 2.2)

  • Y-Axis Spacing: When filters (e.g., severity) are applied, the remaining visible bars maintain their correct vertical spacing (Y-axis positions).

III. Time and Severity Visualization

The tests validate the accurate presentation of time formats and the visualization of severity changes.

Date/Time Display (Section 2.3)

  • Formatted Times: All timestamps in tooltips and the expanded Alerts Table use the correct, formatted local time.
  • Table Status: Start and end times for individual alerts in the Alerts Table accurately reflect their status (timestamp or placeholder text for firing).

Multi-Severity (Section 2.3)

  • Segment Rendering: Incident bars that progressed through multiple severities are verified to display the corresponding multiple colored segments.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the ux-approved Signifies that UX has signed off on this PR label Oct 22, 2025
@DavidRajnoha
Copy link
Contributor Author

/retest

@DavidRajnoha DavidRajnoha changed the title OBSINTA-777: Incident Detection Charts Display Tests OBSINTA-777: [Incidents] Regression for Charts Display Oct 22, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 22, 2025

@DavidRajnoha: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 6ee8b74 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. qe-approved Signifies that QE has signed off on this PR ux-approved Signifies that UX has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants