Skip to content

Conversation

PeterYurkovich
Copy link
Contributor

No description provided.

Fewwy and others added 30 commits September 18, 2025 09:26
OU-833: fix 2 bugs for incidents page
The no-session login did not run the validation code, which
lead to not closing the openshift guide. This commit wraps the
validation login into a cypress command and runs it also with the
no-session login.
…ession-login-fix

NO-JIRA: Login validation for all session flows
RHINENG-20863: improved fetching logic for incidents
NO-JIRA: Improve incidents timeline chart domain and loading UX
…rios

- Implement Prometheus query_range API interception for mocking the
  incidents page data
- Add complete YAML-based incident fixture system with JSON Schema validation
- Support complex incident timelines with severity changes and resolved/ongoing states
- Include 5 predefined incident scenario fixtures
- Add custom Cypress commands: cy.mockIncidents() and cy.mockIncidentFixture()
- Support both YAML and JSON fixture formats
- Add timezone configuration via CYPRESS_TIMEZONE environment variable
  (necessary for correct timeline mocking)
- Implement schema validation with CLI tool for fixture validation
- Add Cursor commands to generate the scenarios in .cursor/commands/

- Add example test demonstrating different mocking approaches
- Integrate mocking system into existing incidents test (01.incidents.cy.ts)
- Add dependencies: ajv, js-yaml, @types/ajv, @types/js-yaml
- Fix Cypress fixtures folder path from 'fixtures' to 'cypress/fixtures'
…s testing

- Add data-test IDs for incidents page components and charts
- Refactor Cypress page objects with improved element selectors
- Update test cases to use new data-test attributes
- Enhance incident search and traversal functionality
OU-989: Kubevirt with fixes after namespace level and session handler
NO-JIRA: fix: immer dependency anr patternfly icons import
…d-data-test-selectors

OBSINTA-795: Data Test Selectors for Incidents Page
NO-JIRA: Update translations for incidents
OU-1015: fix: incidents dropdown stays open fix
cluster:health:components:map was changed to
cluster_health_components_map. This commit updates the mocking to
return the new metric and supports running tests in environments with
old backend and new frontend. This workaround is by default disabled
and will be fully removed after the COO 1.3.0 release
cluster:health:components:map was changed to
cluster_health_components_map. This commit updates the mocking to
return the new metric and supports running tests in environments with
old backend and new frontend. This workaround is by default disabled
and will be fully removed after the COO 1.3.0 release
cluster:health:components:map was changed to
cluster_health_components_map. This commit updates the mocking to
return the new metric and supports running tests in environments with
old backend and new frontend. This workaround is by default disabled
and will be fully removed after the COO 1.3.0 release
The UI changes introduced few quirks that break the traversal of
incidents, but also solved some that had existing workarounds in the
testsuite.

This commit removes the retry for the not loading alerts chart, as it is
loading reliably now, but because stale state is loaded first, it
introduces hard coded wait time.

Additionally, it fixes the failing traversal when no incidents exits in
the UI and adds test case that verifies that on mocked data.
falox and others added 15 commits October 14, 2025 12:14
getIncidentsTimeRanges() used incidentsLastRefreshTime from useSelector immediately after dispatching an update. Since Redux state updates asynchronously, it always received the stale/old value instead of the current time.

- Changed calls to use the local currentTime variable instead of Redux state
- Simplified getIncidentsTimeRanges() signature: removed dispatch parameter and null handling
OU-1030: revert most of my previous changes & avoid flickering when chang…
OCPBUGS-63056, OCPBUGS-63061: Improve alignment with console SDK
OU-1032: resolve stale Redux state bug in incidents time range calculation
OU-1033: close the first dropdown when deselecting incident
- Add getSelectedIncidentAlerts() to retrieve structured alert data
- Add generic table row selectors for flexible table interactions
- Fix timing in incident traversal with deselection wait

Enables more sophisticated test scenarios requiring alert inspection.
…infrastructure-improvement

OBSINTA-858: Improve Cypress Incidents Testing Infrastructure
- Add test for initial incidents loading without filter manipulation (OU-1002)
- Add parameterized tests for dropdown closure on deselection (OU-1033)
  * Tests 3 dropdown types (filter type, severity, days)
  * Tests 2 deselection methods (bar click, chip removal)
- Add test for incident ID filter preservation (OU-1030)
OBSINTA-777: Tests for Incidents Redux Related Regressions
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 22, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 22, 2025

@PeterYurkovich: This pull request references OU-962 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from etmurasaki and zhuje October 22, 2025 13:41
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 22, 2025

@PeterYurkovich: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@PeterYurkovich
Copy link
Contributor Author

/label ux-approved
/label qe-approved
QE and UX already completed on main branch

@openshift-ci openshift-ci bot added ux-approved Signifies that UX has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Oct 22, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 22, 2025

@PeterYurkovich: This pull request references OU-962 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@zhuje
Copy link
Contributor

zhuje commented Oct 22, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PeterYurkovich, zhuje

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [PeterYurkovich,zhuje]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5517668 into openshift:release-coo-0.5 Oct 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR ux-approved Signifies that UX has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.