OU-1004: List perses dashbaords #666
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@zhuje: This pull request references OU-1004 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhuje The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
zhuje
force-pushed
the
ou1004-list-dashboards-pr
branch
2 times, most recently
from
36881db to
be8bd6c
Compare
| const url = `${getDashboardsListUrl(perspective)}?${params.toString()}`; | ||
| navigate(url); |
There was a problem hiding this comment.
This seems to be the same in both cases, it can be extracted out of the if block
There was a problem hiding this comment.
Got it, included in the latest push.
| ); | ||
| }; | ||
|
|
||
| export default MonitoringDashboardListPage; |
There was a problem hiding this comment.
| export default MonitoringDashboardListPage; | |
| export default DashboardListPage; |
There was a problem hiding this comment.
Got it, included in latest push.
| }, | ||
| }); | ||
|
|
||
| const MonitoringDashboardListPage: FC = () => { |
There was a problem hiding this comment.
| const MonitoringDashboardListPage: FC = () => { | |
| const DashboardListPage: FC = () => { |
There was a problem hiding this comment.
Got it, included in latest push.
| } | ||
|
|
||
| const DASHBOARD_COLUMNS = [ | ||
| { label: 'Dashboard', key: 'name' as keyof DashboardRow, index: 0 }, |
There was a problem hiding this comment.
All these values need translations
There was a problem hiding this comment.
Got it, included in latest push.
| [filteredData, sortBy, direction], | ||
| ); | ||
|
|
||
| const pageRows: DataViewTr[] = useMemo( |
There was a problem hiding this comment.
Something to add into a new Jira ticket. But this pages results should be done in the backend, if a cluster has thousands of dashboards we don't want to fetch them all and slice them in the frontend, if the Perses API does not support yet pagination we should add it.
| pagination={<PaginationTool />} | ||
| filters={ | ||
| <DataViewFilters onChange={(_e, values) => onSetFilters(values)} values={filters}> | ||
| <DataViewTextFilter filterId="name" title="Name" placeholder="Filter by name" /> |
There was a problem hiding this comment.
Got it, included in the latest push.
zhuje
force-pushed
the
ou1004-list-dashboards-pr
branch
from
27f7498 to
2648502
Compare
3 participants
JIRA
https://issues.redhat.com/browse/OU-1004
ou1004-list-perses-dashboards.mov