CNV-76395: fix Bonding interface bugs in NNC form

[adamviktora]

This PR fixes some bugs in Node network configuration create form -> step 3 Uplink connection -> Bonding interface

1. maps different Aggregation modes (OVS bonding BALANCE_SLB vs the other Linux bonding options) correctly to the Policy YAML

   • in this doc in the bottom you can see difference between the two

2. able to reselect different Aggregation mode after selection

The core of the select fix is this else part:

else {
    getLinkAggregationSettings(policy).mode = selectedAggregationMode;
  }

Where we update the aggregation mode even if the getBondInterface(policy) or getOVSBridgeBondPort(policy) already exists

3. able to edit Bonding name after Aggregation mode selection

The core of the name bug fix is to always keep bonding name only in one place: either bond interface for Linux bonding getBondInterface(policy) or OVS bridge bond port for OVS bonding getOVSBridgeBondPort(policy).

Demo

Before:

NNC_bonding_before.mp4

After:

NNC_bonding_after.mp4

[openshift-ci-robot]

@adamviktora: This pull request references CNV-76395 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This PR fixes some bugs in Node network configuration create form -> step 3 Uplink connection ->Bonding interface

• maps different Aggregation modes (Linux vs OVS bonding) correctly to the Policy YAML

• able to reselect different Aggregation mode after selection

• able to edit Bonding name after Aggregation mode selection

The core of the name bug fix is to always keep bonding name only in one place: either bond interface for Linux bonding getBondInterface(policy) or OVS bridge bond port for OVS bonding getOVSBridgeBondPort(policy).

The core of the select fix is this else part:

else {
   getLinkAggregationSettings(policy).mode = selectedAggregationMode;
 }

Where we update the aggregation mode even if the getBondInterface(policy) or getOVSBridgeBondPort(policy) already exists

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adamviktora
Once this PR has been reviewed and has the lgtm label, please assign tnisan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@adamviktora: This pull request references CNV-76395 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This PR fixes some bugs in Node network configuration create form -> step 3 Uplink connection ->Bonding interface

1. maps different Aggregation modes (OVS bonding BALANCE_SLB vs the other Linux bonding options) correctly to the Policy YAML

   • in this doc in the bottom you can see difference between the two

2. able to reselect different Aggregation mode after selection

The core of the select fix is this else part:

else {
   getLinkAggregationSettings(policy).mode = selectedAggregationMode;
 }

Where we update the aggregation mode even if the getBondInterface(policy) or getOVSBridgeBondPort(policy) already exists

3. able to edit Bonding name after Aggregation mode selection

The core of the name bug fix is to always keep bonding name only in one place: either bond interface for Linux bonding getBondInterface(policy) or OVS bridge bond port for OVS bonding getOVSBridgeBondPort(policy).

Demo

Before:

NNC_bonding_before.mp4

After:

NNC_bonding_after.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@adamviktora: This pull request references CNV-76395 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This PR fixes some bugs in Node network configuration create form -> step 3 Uplink connection -> Bonding interface

1. maps different Aggregation modes (OVS bonding BALANCE_SLB vs the other Linux bonding options) correctly to the Policy YAML

   • in this doc in the bottom you can see difference between the two

2. able to reselect different Aggregation mode after selection

The core of the select fix is this else part:

else {
   getLinkAggregationSettings(policy).mode = selectedAggregationMode;
 }

Where we update the aggregation mode even if the getBondInterface(policy) or getOVSBridgeBondPort(policy) already exists

3. able to edit Bonding name after Aggregation mode selection

The core of the name bug fix is to always keep bonding name only in one place: either bond interface for Linux bonding getBondInterface(policy) or OVS bridge bond port for OVS bonding getOVSBridgeBondPort(policy).

Demo

Before:

NNC_bonding_before.mp4

After:

NNC_bonding_after.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[adamviktora]

/retest

[openshift-ci]

@adamviktora: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.