-
Notifications
You must be signed in to change notification settings - Fork 82
OADP-6168: Use proper ConfigMap for the repository maintenance job #1896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The CM for the Repository Maintenance do not match the CM layout for the Node Agent. In upstream documentation CM for the Repository Maintenance is the same as for the Node Agent, but implementation is different. Upstream issue: vmware-tanzu/velero#9159 Signed-off-by: Michal Pryc <[email protected]>
@mpryc: This pull request references OADP-6168 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/cherry-pick oadp-1.5 |
@mpryc: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
just waiting on a maintenance job :) |
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Joeavaikath, mpryc, shubham-pampattiwar, sseago, weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mpryc: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@mpryc: new pull request created: #1917 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fixes: OADP-6168
The CM for the Repository Maintenance do not match the CM layout for the Node Agent. In upstream documentation CM for the Repository Maintenance is the same as for the Node Agent, but implementation is different.
Upstream issue: vmware-tanzu/velero#9159
Why the changes were made
To fix: OADP-6168
How to test the changes made
Aligning ConfigMap for the Repository Maintanance Job with the Velero implementation and not Velero documentation.
Tests performed:
'--repo-maintenance-job-configmap=repository-maintenance-velero-sample'