ci change to avoid interactive prompt #1899
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
openshift-ci
bot
added
the
approved
There was a problem hiding this comment.
make install ASSUME_DEFAULT=true
Building kubectl-oadp for current platform (linux/amd64)...
✅ Built kubectl-oadp successfully!
Installing kubectl-oadp to /home/whayutin/.local/bin...
✅ Installed to /home/whayutin/.local/bin
✅ PATH already configured
📋 Configuration:
Setting Velero namespace to: openshift-adp
✅ Client config initialized
📋 Next steps:
1. Test admin commands: kubectl oadp backup get
2. Test non-admin commands: kubectl oadp nonadmin backup get
3. Manage NABSL requests: kubectl oadp nabsl get
4. Change namespace: kubectl oadp client config set namespace=<namespace>
|
/retest |
|
/lgtm |
Joeavaikath
dismissed stale reviews from shubham-pampattiwar, weshayutin, and kaovilai
via
015630d
openshift-ci
bot
removed
lgtm
Joeavaikath
force-pushed
the
cli-install-oadp-cli
branch
from
8d6d194 to
7934b9b
Compare
|
/retest |
|
this is weird...locally it does set the right namespace |
|
see more in slack DM. but maybe need this in CI? |
|
Step e2e-test-cli-aws-e2e succeeded after 54m32s. False alarm from flaky steps post cli e2e /retest |
Refactor OADP CLI installation in CI Dockerfile and e2e tests - Removed direct installation of oadp-cli from the Dockerfile. - Introduced a new CLISetup struct to handle the cloning, building, and installation of oadp-cli in a more structured manner. - Updated e2e tests to utilize the new CLISetup for verifying OADP CLI availability and configuration.
Joeavaikath
force-pushed
the
cli-install-oadp-cli
branch
from
584943f to
f21c30d
Compare
|
/retest-required |
- Changed the installation method from moving to copying the kubectl-oadp binary to /usr/local/bin. - Updated log messages to reflect the change in operation. - Improved error messages for better clarity on failure points.
|
/retest |
openshift-ci
bot
added
the
approved
| if targetPath == fmt.Sprintf("%s/bin/kubectl-oadp", os.Getenv("HOME")) { | ||
| homeBin := fmt.Sprintf("%s/bin", os.Getenv("HOME")) | ||
| currentPath := os.Getenv("PATH") | ||
| if !strings.Contains(currentPath, homeBin) { | ||
| newPath := fmt.Sprintf("%s:%s", homeBin, currentPath) | ||
| os.Setenv("PATH", newPath) | ||
| log.Printf("Added %s to PATH", homeBin) | ||
| } | ||
| } |
There was a problem hiding this comment.
For the curious this is what fixed CI
There was a problem hiding this comment.
well done @kaovilai and @Joeavaikath :)
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Joeavaikath, kaovilai, shubham-pampattiwar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
I think we can stop retesting and override the hcp tests since its nil pointer deref unrelated. |
|
/override ci/prow/4.19-e2e-test-hcp-aws ci/prow/4.20-e2e-test-hcp-aws |
|
@kaovilai: Overrode contexts on behalf of kaovilai: ci/prow/4.19-e2e-test-hcp-aws, ci/prow/4.20-e2e-test-hcp-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@Joeavaikath: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Why the changes were made
Moves the install to within the cli e2e test suite.
How to test the changes made
cli e2e should run without any issues. ci-Dockerfile only has kubectl install now.