CLID-476: Fixes for cross-build errors #1303

dorzel · 2025-11-03T18:01:19Z

Description

I noticed when cross-building for ppc64le that make was erroring while trying to pass GO_BUILD_FLAGS as positional arguments. Cross-builds were also failing with CGO due to unknown ASM instructions while translating the assembly.

Also set GO_BUILD_BINDIR in the build step so one can run cross-builds first, without having already run make build. (It was assuming v1/bin/oc-mirror existed regardless of the value of GO_BUILD_BINDIR).

Github / Jira issue:

None

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Code Improvements (Refactoring, Performance, CI upgrades, etc)
Internal repo assets (diagrams / docs on github repo)
This change requires a documentation update on openshift docs

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

make clean
make tidy
make cross-build
make build

Expected Outcome

Please describe the outcome expected from the tests.

cross-builds properly build and populate /bin without errors.

aguidirh

Hi @dorzel,

Thanks for the PR. I tested make cross-build and it worked fine as expected.

I added only one concern I have to the PR.

Makefile

openshift-ci-robot · 2025-11-04T17:38:51Z

@dorzel: This pull request references CLID-476 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Description

I noticed when cross-building for ppc64le that make was erroring while trying to pass GO_BUILD_FLAGS as positional arguments. Cross-builds were also failing with CGO due to unknown ASM instructions while translating the assembly.

Also set GO_BUILD_BINDIR in the build step so one can run cross-builds first, without having already run make build. (It was assuming v1/bin/oc-mirror existed regardless of the value of GO_BUILD_BINDIR).

Github / Jira issue:

None

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

New feature (non-breaking change which adds functionality)

Breaking change (fix or feature that would cause existing functionality to not work as expected)

Code Improvements (Refactoring, Performance, CI upgrades, etc)

Internal repo assets (diagrams / docs on github repo)

This change requires a documentation update on openshift docs

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

make clean
make tidy
make cross-build
make build

Expected Outcome

Please describe the outcome expected from the tests.

cross-builds properly build and populate /bin without errors.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

dorzel · 2025-11-04T18:10:37Z

/jira refresh

openshift-ci-robot · 2025-11-04T18:10:41Z

@dorzel: This pull request references CLID-476 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

dorzel · 2025-11-17T18:25:57Z

Ok, I think the latest changes solve it nicely. The conditional assignment allows for:

preserving all default CGO behavior (due to not exporting the variable)
defaulting cross-build targets to CGO_ENABLED=0 (makefile is not "broken" by default for standard users)
overrides for CGO_ENABLED passed via CLI are favored for all targets

dorzel · 2025-11-17T20:35:25Z

/retest

dorzel · 2025-11-17T21:28:13Z

/test v1-e2e

dorzel · 2025-11-18T16:31:07Z

/retest

aguidirh

Thanks @dorzel for taking into account the suggestions.

I ran some tests and it worked as expected on my side.

I will approve and let LGTM to @r4f4.

aguidirh · 2025-11-20T10:45:42Z

Makefile

 GO_BUILD_PACKAGES := ./cmd/oc-mirror
 GO_PACKAGE = github.com/openshift/oc-mirror/v2

+# Default to CGO_ENABLED=0 for cross-builds, but allow override from command line


nit: it would be nice to add in the comment the reason why it is needed to disable CGO for cross-builds.

Due to the complexity of managing C cross-compiler toolchains, cross-building with CGO_ENABLED on the non-native architecture is not supported.

openshift-ci · 2025-11-20T10:48:05Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aguidirh, dorzel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [aguidirh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

r4f4

/lgtm

prb112 · 2025-12-05T04:08:34Z

Hey @dorzel I was just made aware of this one. Do you happen to have the log of the failure?

dorzel · 2025-12-05T16:26:08Z

Hey @prb112 the error occurs when CGO is enabled but the user does not have the required toolchains/compilers in place to properly use CGO for cross-compilation. This can be expected, but it does result in failure by default for the common use case for those users building from source, which is cross-compiling a static executable for a different arch.

Error ends up being many lines of "no such instruction", among others:

...
Makefile:53: warning: overriding recipe for target 'test-unit'
/home/dorzel/go/pkg/mod/github.com/openshift/[email protected]/make/targets/golang/test-unit.mk:7: warning: ignoring old recipe for target 'test-unit'
mkdir -p './bin/linux-ppc64le'
go build -mod=readonly -tags "json1 " -ldflags "-X github.com/openshift/oc-mirror/pkg/version.versionFromGit="v0.2.0-alpha.1-494-g140e7ee" -X github.com/openshift/oc-mirror/pkg/version.commitFromGit="140e7ee4" -X github.com/openshift/oc-mirror/pkg/version.gitTreeState="clean" -X github.com/openshift/oc-mirror/pkg/version.buildDate="2025-12-05T16:18:10Z" " -o './bin/linux-ppc64le/oc-mirror' github.com/openshift/oc-mirror/cmd/oc-mirror
gcc_linux_ppc64x.S: Assembler messages:
gcc_linux_ppc64x.S:50: Error: no such instruction: `mflr %r0'
gcc_linux_ppc64x.S:51: Error: bad register name `%r0'
gcc_linux_ppc64x.S:52: Error: no such instruction: `mfcr %r0'
gcc_linux_ppc64x.S:53: Error: bad register name `%r0'
gcc_linux_ppc64x.S:54: Error: no such instruction: `stdu %r1,-FRAME_SIZE(%r1)'
gcc_linux_ppc64x.S:55: Error: bad register name `%r2'
gcc_linux_ppc64x.S:20: Error: junk `(1)' after expression
gcc_linux_ppc64x.S:57:  Info: macro invoked from here
gcc_linux_ppc64x.S:20: Error: number of operands mismatch for `std'
gcc_linux_ppc64x.S:57:  Info: macro invoked from here
gcc_linux_ppc64x.S:20: Error: junk `(1)' after expression
gcc_linux_ppc64x.S:21:  Info: macro invoked from here
gcc_linux_ppc64x.S:57:   Info: macro invoked from here
gcc_linux_ppc64x.S:20: Error: number of operands mismatch for `std'
gcc_linux_ppc64x.S:21:  Info: macro invoked from here
gcc_linux_ppc64x.S:57:   Info: macro invoked from here
gcc_linux_ppc64x.S:20: Error: junk `(1)' after expression
gcc_linux_ppc64x.S:21:  Info: macro invoked from here
gcc_linux_ppc64x.S:21:   Info: macro invoked from here
gcc_linux_ppc64x.S:57:    Info: macro invoked from here
gcc_linux_ppc64x.S:20: Error: number of operands mismatch for `std'
gcc_linux_ppc64x.S:21:  Info: macro invoked from here
gcc_linux_ppc64x.S:21:   Info: macro invoked from here
gcc_linux_ppc64x.S:57:    Info: macro invoked from here
gcc_linux_ppc64x.S:20: Error: junk `(1)' after expression
gcc_linux_ppc64x.S:21:  Info: macro invoked from here
...
gcc_linux_ppc64x.S:76: Error: no such instruction: `ld %r2,24(%r1)'
gcc_linux_ppc64x.S:77: Error: no such instruction: `addi %r1,%r1,FRAME_SIZE'
gcc_linux_ppc64x.S:78: Error: no such instruction: `ld %r0,16(%r1)'
gcc_linux_ppc64x.S:79: Error: no such instruction: `mtlr %r0'
gcc_linux_ppc64x.S:80: Error: no such instruction: `ld %r0,8(%r1)'
gcc_linux_ppc64x.S:81: Error: no such instruction: `mtcr %r0'
gcc_linux_ppc64x.S:82: Error: no such instruction: `blr'
make[2]: *** [/home/dorzel/go/pkg/mod/github.com/openshift/[email protected]/make/targets/golang/build.mk:16: build] Error 1
make[1]: *** [Makefile:86: build] Error 2
make: *** [Makefile:97: cross-build-linux-ppc64le] Error 2

prb112 · 2025-12-05T18:37:56Z

Hey Dylan This doesn't feel like the right answer. It feel like there is an issue with the local golang source. e.g. you have multiple sources.
If you download golang again (you have two golang assembly files).

mkdir -p /usr/local2
subscription-manager repos --enable codeready-builder-for-rhel-9-ppc64le-rpms
dnf install -y https://dl.fedoraproject.org/pub/epel/epel-release-latest-9.noarch.rpm
dnf install -y  libassuan-devel gpgme-devel libgpg-error-devel btrfs-progs-devel.ppc64le podman git jq tar  gcc   make   git   gpgme-devel  libassuan-devel   wget   pigz   procps-ng 
GO_VERSION=go1.25.4 && curl -sL https://golang.org/dl/${GO_VERSION}.linux-ppc64le.tar.gz       \
        | tar xzvf - --directory /usr/local2/                                    \
     && /usr/local2/go/bin/go version                                            \
     && ln -f /usr/local2/go/bin/go /usr/bin/go
export PATH=/usr/local2/go/bin:$PATH:~/go/bin/:
export GOROOT="/usr/local2/go"

prb112 · 2025-12-05T18:38:03Z

better try on a fresh vm

openshift-ci · 2025-12-09T20:30:56Z

New changes are detected. LGTM label has been removed.

openshift-ci · 2025-12-09T20:47:31Z

@dorzel: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci bot requested review from aguidirh and r4f4 November 3, 2025 18:02

aguidirh reviewed Nov 4, 2025

View reviewed changes

Makefile Outdated Show resolved Hide resolved

dorzel changed the title ~~Fixes for cross-build errors~~ CLID-476: Fixes for cross-build errors Nov 4, 2025

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 4, 2025

dorzel force-pushed the cross-builds branch 2 times, most recently from 1b00086 to 140e7ee Compare November 17, 2025 18:19

aguidirh approved these changes Nov 20, 2025

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2025

r4f4 reviewed Dec 3, 2025

View reviewed changes

openshift-ci bot assigned r4f4 Dec 3, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2025

Fix errors with cross-build build flags and CGO

3de8db8

dorzel force-pushed the cross-builds branch from 140e7ee to 3de8db8 Compare December 9, 2025 20:30

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2025

CLID-476: Fixes for cross-build errors #1303

Are you sure you want to change the base?

CLID-476: Fixes for cross-build errors #1303

Uh oh!

Conversation

dorzel commented Nov 3, 2025

Description

Type of change

How Has This Been Tested?

Expected Outcome

Uh oh!

aguidirh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 4, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

How Has This Been Tested?

Expected Outcome

Uh oh!

dorzel commented Nov 4, 2025

Uh oh!

openshift-ci-robot commented Nov 4, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dorzel commented Nov 17, 2025

Uh oh!

dorzel commented Nov 17, 2025

Uh oh!

dorzel commented Nov 17, 2025

Uh oh!

dorzel commented Nov 18, 2025

Uh oh!

aguidirh left a comment

Choose a reason for hiding this comment

Uh oh!

aguidirh Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

prb112 Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Nov 20, 2025

Uh oh!

r4f4 left a comment

Choose a reason for hiding this comment

Uh oh!

prb112 commented Dec 5, 2025

Uh oh!

dorzel commented Dec 5, 2025

Uh oh!

prb112 commented Dec 5, 2025

Uh oh!

prb112 commented Dec 5, 2025

Uh oh!

openshift-ci bot commented Dec 9, 2025

Uh oh!

openshift-ci bot commented Dec 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

openshift-ci-robot commented Nov 4, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Nov 4, 2025 •

edited by openshift-ci bot

Loading