Skip to content

Conversation

@aguidirh
Copy link
Contributor

@aguidirh aguidirh commented Dec 4, 2025

Description

This is a manual backport of PR #1306

This PR updates the catalog-filter dependency from v0.0.4 to v0.0.5 to fix an issue where oc-mirror was unable to properly mirror specific versions of operators (e.g., redis-enterprise-operator-cert) when using minVersion and maxVersion fields in the ImageSetConfiguration.

The updated catalog-filter library provides improved error handling and validation for version range filtering, resulting in more accurate error messages when specific versions cannot be found in operator catalogs.

Github / Jira issue:

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

With the following ImageSetConfig:

kind: ImageSetConfiguration
apiVersion: mirror.openshift.io/v1alpha2
mirror:
  operators:
    - catalog: registry.redhat.io/redhat/redhat-operator-index:v4.16
      packages:
      - name: rhbk-operator
        defaultChannel: stable-v26
        channels:
        - name: 'stable-v26'
          maxVersion: '26.0.8-opr.1'
          minVersion: '26.0.8-opr.1'

Run m2m

Expected Outcome

  • Only the version 26.0.8-opr.1 should be inside of the custom catalog.

Signed-off-by: Alex Guidi <[email protected]>
@openshift-ci openshift-ci bot requested a review from r4f4 December 4, 2025 15:09
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2025
@aguidirh aguidirh changed the title Manual backport of PR 1306 fix: return only requested version Dec 4, 2025
@aguidirh
Copy link
Contributor Author

aguidirh commented Dec 4, 2025

/jira cherrypick OCPBUGS-64647

@openshift-ci-robot
Copy link

@aguidirh: Jira Issue OCPBUGS-64647 has been cloned as Jira Issue OCPBUGS-66410. Will retitle bug to link to clone.
/retitle OCPBUGS-66410: fix: return only requested version

In response to this:

/jira cherrypick OCPBUGS-64647

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title fix: return only requested version OCPBUGS-66410: fix: return only requested version Dec 4, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Dec 4, 2025
@openshift-ci-robot
Copy link

@aguidirh: This pull request references Jira Issue OCPBUGS-66410, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.z) matches configured target version for branch (4.19.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-64647 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-64647 targets the "4.20.z" version, which is one of the valid target versions: 4.20.0, 4.20.z
  • bug has dependents

Requesting review from QA contact:
/cc @nidangavali

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Description

This is a manual backport of PR #1306

This PR updates the catalog-filter dependency from v0.0.4 to v0.0.5 to fix an issue where oc-mirror was unable to properly mirror specific versions of operators (e.g., redis-enterprise-operator-cert) when using minVersion and maxVersion fields in the ImageSetConfiguration.

The updated catalog-filter library provides improved error handling and validation for version range filtering, resulting in more accurate error messages when specific versions cannot be found in operator catalogs.

Github / Jira issue:

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

With the following ImageSetConfig:

kind: ImageSetConfiguration
apiVersion: mirror.openshift.io/v1alpha2
mirror:
 operators:
   - catalog: registry.redhat.io/redhat/redhat-operator-index:v4.16
     packages:
     - name: rhbk-operator
       defaultChannel: stable-v26
       channels:
       - name: 'stable-v26'
         maxVersion: '26.0.8-opr.1'
         minVersion: '26.0.8-opr.1'

Run m2m

Expected Outcome

  • Only the version 26.0.8-opr.1 should be inside of the custom catalog.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from nidangavali December 4, 2025 15:10
Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2025
@openshift-ci
Copy link

openshift-ci bot commented Dec 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aguidirh, r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aguidirh
Copy link
Contributor Author

aguidirh commented Dec 4, 2025

/retest

1 similar comment
@aguidirh
Copy link
Contributor Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Dec 10, 2025

@aguidirh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@MayXuQQ
Copy link

MayXuQQ commented Dec 11, 2025

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Dec 11, 2025
@openshift-ci-robot
Copy link

@MayXuQQ: This PR has been marked as verified by [OCP-86252 - [OCPBUGS-61497] return only requested version](https://polarion.engineering.redhat.com/polarion/redirect/project/OSE/workitem?id=OCP-86252).

In response to this:

/verified by OCP-86252 - [OCPBUGS-61497] return only requested version

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants