Second attempt at replacing GCP/Google Cloud Platform with attributes #101036
+931
−928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
size/XXL
|
🤖 Fri Oct 24 18:42:18 - Prow CI generated the docs preview: |
installing/installing_gcp/installing-restricted-networks-gcp-installer-provisioned.adoc
Show resolved
Hide resolved
...iguration/configuring-multi-arch-compute-machines/creating-multi-arch-compute-nodes-gcp.adoc
Show resolved
Hide resolved
modules/persistent-storage-csi-gcp-hyperdisk-storage-pools-procedure.adoc
Outdated
Show resolved
Hide resolved
bscott-rh
force-pushed
the
replace-gcp-attr-context
branch
from
9751b70 to
c8de82b
Compare
|
@bscott-rh: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where #100535 replaced all instances with {gcp-full}, this PR instead attempts to contextually replace:
Google Cloud Platform (GCP) with {gcp-first}
Google Cloud Platform with {gcp-full}
Google Cloud with {gcp-full}
GCP with {gcp-short}
4.12+
https://issues.redhat.com/browse/OSDOCS-16547
Preview: https://101036--ocpdocs-pr.netlify.app/openshift-enterprise/latest/welcome/