-
Couldn't load subscription status.
- Fork 1.8k
OSDOCS-16547 Second attempt at replacing GCP/Google Cloud Platform with attributes #101036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🤖 Tue Oct 28 18:02:39 - Prow CI generated the docs preview: |
installing/installing_gcp/installing-restricted-networks-gcp-installer-provisioned.adoc
Show resolved
Hide resolved
...iguration/configuring-multi-arch-compute-machines/creating-multi-arch-compute-nodes-gcp.adoc
Show resolved
Hide resolved
modules/persistent-storage-csi-gcp-hyperdisk-storage-pools-procedure.adoc
Outdated
Show resolved
Hide resolved
9751b70 to
c8de82b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One stray attribute in the topic map. Machine mgmt content LGTM, also scanned over CCO stuff since I originated a lot of it. Noticed one GUI thing in a nearby file, not sure if there is anything to do about that or others like it.
Thank you SO MUCH for doing this!!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, what a huge 🥙 😅
- Scanned through diffs for oddities
- Checked the assemblies in the output since those are the place I'd most expect to see issues (because of having to move the
include::_attributes/common-attributes.adoc[]line) - Spot-checked text in all impacted distro previewss, but definitely not all files. Looked for any that seemed like more than a straightforward replacement of plain text.
- Happy to rereview any subsequent commits
- Don't forget to squash
- Lmk if you need eyes on the cherrypicks. I wonder if there is a way to show resolved merge conflicts as a separate commit 🤔
/remove-label merge-review-in-progress
/remove-label merge-review-needed
1e9c786 to
330911a
Compare
|
@bscott-rh: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-4.21 |
|
@bscott-rh: #101036 failed to apply on top of branch "enterprise-4.21": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick enterprise-4.19 |
|
@bscott-rh: #101036 failed to apply on top of branch "enterprise-4.19": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick enterprise-4.20 |
|
@bscott-rh: new pull request created: #101252 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Where #100535 replaced all instances with {gcp-full}, this PR instead attempts to contextually replace:
Google Cloud Platform (GCP) with {gcp-first}
Google Cloud Platform with {gcp-full}
Google Cloud with {gcp-full}
GCP with {gcp-short}
4.12+
https://issues.redhat.com/browse/OSDOCS-16547
Preview: https://101036--ocpdocs-pr.netlify.app/openshift-enterprise/latest/welcome/