Skip to content

Conversation

@bscott-rh
Copy link
Contributor

@bscott-rh bscott-rh commented Oct 23, 2025

Where #100535 replaced all instances with {gcp-full}, this PR instead attempts to contextually replace:

Google Cloud Platform (GCP) with {gcp-first}
Google Cloud Platform with {gcp-full}
Google Cloud with {gcp-full}
GCP with {gcp-short}

4.12+
https://issues.redhat.com/browse/OSDOCS-16547

Preview: https://101036--ocpdocs-pr.netlify.app/openshift-enterprise/latest/welcome/

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 23, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 23, 2025

🤖 Tue Oct 28 18:02:39 - Prow CI generated the docs preview:
https://101036--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@bscott-rh bscott-rh force-pushed the replace-gcp-attr-context branch from 9751b70 to c8de82b Compare October 24, 2025 18:30
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One stray attribute in the topic map. Machine mgmt content LGTM, also scanned over CCO stuff since I originated a lot of it. Noticed one GUI thing in a nearby file, not sure if there is anything to do about that or others like it.

Thank you SO MUCH for doing this!!!!

@bscott-rh bscott-rh changed the title Second attempt at replacing GCP/Google Cloud Platform with attributes OSDOCS-16547 Second attempt at replacing GCP/Google Cloud Platform with attributes Oct 27, 2025
@jeana-redhat jeana-redhat added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Oct 28, 2025
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, what a huge 🥙 😅

  • Scanned through diffs for oddities
  • Checked the assemblies in the output since those are the place I'd most expect to see issues (because of having to move the include::_attributes/common-attributes.adoc[] line)
  • Spot-checked text in all impacted distro previewss, but definitely not all files. Looked for any that seemed like more than a straightforward replacement of plain text.
  1. Happy to rereview any subsequent commits
  2. Don't forget to squash
  3. Lmk if you need eyes on the cherrypicks. I wonder if there is a way to show resolved merge conflicts as a separate commit 🤔

/remove-label merge-review-in-progress
/remove-label merge-review-needed

@openshift-ci openshift-ci bot removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Oct 28, 2025
@jeana-redhat jeana-redhat added this to the Continuous Release milestone Oct 28, 2025
@bscott-rh bscott-rh force-pushed the replace-gcp-attr-context branch from 1e9c786 to 330911a Compare October 28, 2025 17:48
@openshift-ci
Copy link

openshift-ci bot commented Oct 28, 2025

@bscott-rh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bscott-rh bscott-rh merged commit efa9971 into openshift:main Oct 28, 2025
2 checks passed
@bscott-rh
Copy link
Contributor Author

/cherrypick enterprise-4.21

@openshift-cherrypick-robot

@bscott-rh: #101036 failed to apply on top of branch "enterprise-4.21":

Applying: gcp-first replacement
.git/rebase-apply/patch:6956: trailing whitespace.
<7> Specify the {gcp-short} region, such as `us-central1`. 
.git/rebase-apply/patch:7441: trailing whitespace.
To create a {gcp-first} cluster with multi-architecture compute machines, you must first create a single-architecture {gcp-short} installer-provisioned cluster with the multi-architecture installer binary. For more information on AWS installations, see xref:../../installing/installing_gcp/installing-gcp-customizations.adoc[Installing a cluster on {gcp-short} with customizations]. 
warning: 2 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	_topic_maps/_topic_map.yml
M	installing/overview/installing-preparing.adoc
M	migrating_from_ocp_3_to_4/planning-migration-3-4.adoc
M	modules/installation-configure-proxy.adoc
M	modules/logging-loki-cli-install.adoc
M	modules/logging-loki-gui-install.adoc
M	modules/nw-egress-ips-about.adoc
M	modules/nw-udn-limitations.adoc
M	modules/oadp-s3-compatible-backup-storage-providers.adoc
M	windows_containers/wmco_rn/windows-containers-release-notes-prereqs.adoc
Falling back to patching base and 3-way merge...
Auto-merging windows_containers/wmco_rn/windows-containers-release-notes-prereqs.adoc
Auto-merging modules/oadp-s3-compatible-backup-storage-providers.adoc
Auto-merging modules/nw-udn-limitations.adoc
CONFLICT (content): Merge conflict in modules/nw-udn-limitations.adoc
Auto-merging modules/nw-egress-ips-about.adoc
Auto-merging modules/logging-loki-gui-install.adoc
Auto-merging modules/logging-loki-cli-install.adoc
Auto-merging modules/installation-configure-proxy.adoc
Auto-merging migrating_from_ocp_3_to_4/planning-migration-3-4.adoc
Auto-merging installing/overview/installing-preparing.adoc
Auto-merging _topic_maps/_topic_map.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 gcp-first replacement

In response to this:

/cherrypick enterprise-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bscott-rh
Copy link
Contributor Author

/cherrypick enterprise-4.19

@openshift-cherrypick-robot

@bscott-rh: #101036 failed to apply on top of branch "enterprise-4.19":

Applying: gcp-first replacement
Using index info to reconstruct a base tree...
M	_topic_maps/_topic_map.yml
M	_topic_maps/_topic_map_osd.yml
M	backup_and_restore/application_backup_and_restore/installing/installing-oadp-gcp.adoc
M	installing/installing_gcp/installing-gcp-customizations.adoc
M	installing/installing_gcp/installing-gcp-network-customizations.adoc
M	installing/installing_gcp/installing-gcp-private.adoc
M	installing/installing_gcp/installing-gcp-shared-vpc.adoc
M	installing/installing_gcp/installing-gcp-user-infra-vpc.adoc
M	installing/installing_gcp/installing-gcp-user-infra.adoc
M	installing/installing_gcp/installing-gcp-vpc.adoc
M	installing/installing_gcp/installing-restricted-networks-gcp-installer-provisioned.adoc
M	installing/installing_gcp/installing-restricted-networks-gcp.adoc
M	installing/installing_gcp/preparing-to-install-on-gcp.adoc
M	installing/overview/installing-preparing.adoc
M	migrating_from_ocp_3_to_4/planning-migration-3-4.adoc
M	modules/cco-ccoctl-creating-at-once.adoc
M	modules/cco-ccoctl-install-creating-manifests.adoc
M	modules/ccs-gcp-customer-procedure-wif.adoc
M	modules/ccs-gcp-provisioned.adoc
M	modules/create-wif-cluster-cli.adoc
M	modules/create-wif-cluster-ocm.adoc
M	modules/distr-tracing-tempo-install-tempomonolithic-web-console.adoc
M	modules/distr-tracing-tempo-install-tempostack-web-console.adoc
M	modules/distr-tracing-tempo-install-web-console.adoc
M	modules/gcp-limits.adoc
M	modules/installation-configuration-parameters.adoc
M	modules/installation-configure-proxy.adoc
M	modules/installation-gcp-tested-machine-types-arm.adoc
M	modules/installation-gcp-tested-machine-types.adoc
M	modules/installation-initializing.adoc
M	modules/installation-launching-installer.adoc
M	modules/installation-special-config-rtkernel.adoc
M	modules/log6x-quickstart-opentelemetry.adoc
M	modules/log6x-quickstart-viaq.adoc
M	modules/logging-loki-cli-install.adoc
M	modules/logging-loki-gui-install.adoc
M	modules/machineset-gcp-confidential-vm.adoc
M	modules/manually-create-identity-access-management.adoc
M	modules/minimum-required-permissions-ipi-gcp-xpn.adoc.git/rebase-apply/patch:6956: trailing whitespace.
<7> Specify the {gcp-short} region, such as `us-central1`. 
.git/rebase-apply/patch:7441: trailing whitespace.
To create a {gcp-first} cluster with multi-architecture compute machines, you must first create a single-architecture {gcp-short} installer-provisioned cluster with the multi-architecture installer binary. For more information on AWS installations, see xref:../../installing/installing_gcp/installing-gcp-customizations.adoc[Installing a cluster on {gcp-short} with customizations]. 
warning: 2 lines add whitespace errors.

M	modules/minimum-required-permissions-ipi-gcp.adoc
M	modules/network-observability-loki-install.adoc
M	modules/nodes-nodes-rtkernel-arguments.adoc
M	modules/nvidia-gpu-gcp-adding-a-gpu-node.adoc
M	modules/nw-egress-ips-about.adoc
M	modules/oadp-s3-compatible-backup-storage-providers.adoc
M	modules/osd-create-cluster-ccs.adoc
M	modules/osd-create-cluster-red-hat-account.adoc
M	modules/osd-intro.adoc
M	modules/persistent-storage-csi-manila-dynamic-provisioning.adoc
M	modules/sdpolicy-security.adoc
M	observability/distr_tracing/distr-tracing-tempo-installing.adoc
M	observability/logging/logging-6.0/log6x-about.adoc
M	osd_whats_new/osd-whats-new.adoc
M	post_installation_configuration/configuring-multi-arch-compute-machines/multi-architecture-configuration.adoc
M	storage/container_storage_interface/persistent-storage-csi-google-cloud-file.adoc
M	updating/updating_a_cluster/migrating-to-multi-payload.adoc
M	windows_containers/wmco_rn/windows-containers-release-notes-prereqs.adoc
Falling back to patching base and 3-way merge...
Auto-merging windows_containers/wmco_rn/windows-containers-release-notes-prereqs.adoc
Auto-merging updating/updating_a_cluster/migrating-to-multi-payload.adoc
CONFLICT (content): Merge conflict in updating/updating_a_cluster/migrating-to-multi-payload.adoc
Auto-merging storage/container_storage_interface/persistent-storage-csi-google-cloud-file.adoc
Auto-merging post_installation_configuration/configuring-multi-arch-compute-machines/multi-architecture-configuration.adoc
Auto-merging osd_whats_new/osd-whats-new.adoc
Auto-merging observability/logging/logging-6.0/log6x-about.adoc
Auto-merging observability/distr_tracing/distr-tracing-tempo-installing.adoc
Auto-merging modules/sdpolicy-security.adoc
Auto-merging modules/persistent-storage-csi-manila-dynamic-provisioning.adoc
Auto-merging modules/osd-intro.adoc
Auto-merging modules/osd-create-cluster-red-hat-account.adoc
Auto-merging modules/osd-create-cluster-ccs.adoc
Auto-merging modules/oadp-s3-compatible-backup-storage-providers.adoc
Auto-merging modules/nw-egress-ips-about.adoc
Auto-merging modules/nvidia-gpu-gcp-adding-a-gpu-node.adoc
Auto-merging modules/nodes-nodes-rtkernel-arguments.adoc
Auto-merging modules/network-observability-loki-install.adoc
Auto-merging modules/minimum-required-permissions-ipi-gcp.adoc
Auto-merging modules/minimum-required-permissions-ipi-gcp-xpn.adoc
Auto-merging modules/manually-create-identity-access-management.adoc
Auto-merging modules/machineset-gcp-confidential-vm.adoc
Auto-merging modules/logging-loki-gui-install.adoc
Auto-merging modules/logging-loki-cli-install.adoc
Auto-merging modules/log6x-quickstart-viaq.adoc
Auto-merging modules/log6x-quickstart-opentelemetry.adoc
Auto-merging modules/installation-special-config-rtkernel.adoc
Auto-merging modules/installation-launching-installer.adoc
Auto-merging modules/installation-initializing.adoc
Auto-merging modules/installation-gcp-tested-machine-types.adoc
Auto-merging modules/installation-gcp-tested-machine-types-arm.adoc
Auto-merging modules/installation-configure-proxy.adoc
Auto-merging modules/installation-configuration-parameters.adoc
Auto-merging modules/gcp-limits.adoc
CONFLICT (content): Merge conflict in modules/gcp-limits.adoc
Auto-merging modules/distr-tracing-tempo-install-web-console.adoc
Auto-merging modules/distr-tracing-tempo-install-tempostack-web-console.adoc
Auto-merging modules/distr-tracing-tempo-install-tempomonolithic-web-console.adoc
Auto-merging modules/create-wif-cluster-ocm.adoc
Auto-merging modules/create-wif-cluster-cli.adoc
CONFLICT (content): Merge conflict in modules/create-wif-cluster-cli.adoc
Auto-merging modules/ccs-gcp-provisioned.adoc
CONFLICT (content): Merge conflict in modules/ccs-gcp-provisioned.adoc
Auto-merging modules/ccs-gcp-customer-procedure-wif.adoc
Auto-merging modules/cco-ccoctl-install-creating-manifests.adoc
Auto-merging modules/cco-ccoctl-creating-at-once.adoc
Auto-merging migrating_from_ocp_3_to_4/planning-migration-3-4.adoc
Auto-merging installing/overview/installing-preparing.adoc
CONFLICT (content): Merge conflict in installing/overview/installing-preparing.adoc
Auto-merging installing/installing_gcp/preparing-to-install-on-gcp.adoc
CONFLICT (content): Merge conflict in installing/installing_gcp/preparing-to-install-on-gcp.adoc
Auto-merging installing/installing_gcp/installing-restricted-networks-gcp.adoc
Auto-merging installing/installing_gcp/installing-restricted-networks-gcp-installer-provisioned.adoc
Auto-merging installing/installing_gcp/installing-gcp-vpc.adoc
Auto-merging installing/installing_gcp/installing-gcp-user-infra.adoc
Auto-merging installing/installing_gcp/installing-gcp-user-infra-vpc.adoc
Auto-merging installing/installing_gcp/installing-gcp-shared-vpc.adoc
Auto-merging installing/installing_gcp/installing-gcp-private.adoc
Auto-merging installing/installing_gcp/installing-gcp-network-customizations.adoc
Auto-merging installing/installing_gcp/installing-gcp-customizations.adoc
Auto-merging backup_and_restore/application_backup_and_restore/installing/installing-oadp-gcp.adoc
Auto-merging _topic_maps/_topic_map_osd.yml
Auto-merging _topic_maps/_topic_map.yml
CONFLICT (content): Merge conflict in _topic_maps/_topic_map.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 gcp-first replacement

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bscott-rh
Copy link
Contributor Author

/cherrypick enterprise-4.20

@openshift-cherrypick-robot

@bscott-rh: new pull request created: #101252

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants