fixing up issues for bad sshKey declaration in install-config.yaml

[Ultimate-etamitlU]

Fixing up issues for bad sshKey declaration in install-config.yaml
and removing additional spaces before "EOF" for sample configs files
of agent-config.yaml and install-config.yaml
Signed-off-by: Ultimate-etamitlU [email protected]

Version(s): 4.13 and above

Issue:
In https://github.com/openshift/openshift-docs/edit/main/modules/installing-ocp-agent-inputs.adoc
we have sample install-config as,
..
..
pullSecret: '<pull_secret>' <4>
sshKey: |
'<ssh_pub_key>' <5>
..
..
But when we add ssh key like that if fails to start services that creates initial cluster and infraenv though the node gets IP but we can't do ssh.
Changing it to something like below fixes it.
What needs fixing?

From this,

..
..
pullSecret: '<pull_secret>' <4>
sshKey: |
'<ssh_pub_key>' <5>
..
..

To this,

..
..
pullSecret: '<pull_secret>' <4>
sshKey: '<ssh_pub_key>' <5>
..
..

Tested this to my environment and seems not working with ABI somehow.

Also there are white spaces before "EOF" which break the copy paste operation of
the sample configs for user and needs that's adjusted manually so removing those.

Link to docs preview:

QE review:

• QE has approved this change.

Additional information:

Earlier had separate PR for each of it and messed up with that by trying it by GUI so
correcting everything in a single commit to avoid kids noise!

[ocpdocs-previewbot]

🤖 Build preview is available at:
https://66190--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/27760

[Ultimate-etamitlU]

@skopacz1 Erased all of the separates PR's I had and combined them all to one with this fresh one, can you please review this one.
Apologies as I thought using GUI would be easy to do this and it ended up in a lot work.

[skopacz1]

LGTM. This is a redo of #66032 which was QE approved, so I believe this PR itself won't need QE review. Let me know if I need it reviewed anyways.

[skopacz1]

/label merge-review-needed

[kalexand-rh]

Since QE approved the other PR, it's fine to merge this one - it does appear to be the same change.

[kcarmichael08]

/cherrypick enterprise-4.14

[openshift-cherrypick-robot]

@kcarmichael08: new pull request created: #66207

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kcarmichael08]

/cherrypick enterprise-4.13

[openshift-cherrypick-robot]

@kcarmichael08: #66190 failed to apply on top of branch "enterprise-4.13":

Applying: fixing up issues for bad sshKey declaration in install-config.yaml and removing additional spaces before "EOF" for sample configs files of agent-config.yaml and install-config.yaml Signed-off-by: Ultimate-etamitlU <[email protected]>
Using index info to reconstruct a base tree...
M	modules/installing-ocp-agent-inputs.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installing-ocp-agent-inputs.adoc
CONFLICT (content): Merge conflict in modules/installing-ocp-agent-inputs.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fixing up issues for bad sshKey declaration in install-config.yaml and removing additional spaces before "EOF" for sample configs files of agent-config.yaml and install-config.yaml Signed-off-by: Ultimate-etamitlU <[email protected]>
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.