Skip to content

Conversation

@shahsahil264
Copy link

@shahsahil264 shahsahil264 commented Jul 11, 2024

Version(s): 4.15+

Issue: https://issues.redhat.com/browse/CHAOS-832

Link to docs preview:

🤖 Thu Jul 11 11:51:50 - Prow CI generated the docs preview:

https://78769--ocpdocs-pr.netlify.app/

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 11, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 11, 2024

🤖 Tue Feb 25 17:11:11 - Prow CI generated the docs preview:

https://78769--ocpdocs-pr.netlify.app/

@shahsahil264
Copy link
Author

@openshift/team-documentation

@shahsahil264
Copy link
Author

@chaitanyaenr

@shahsahil264
Copy link
Author

@ahardin-rh PTAL. Thanks.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 10, 2024
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 9, 2024
@shahsahil264
Copy link
Author

/remove-lifecycle stale

@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Dec 19, 2024
@openshift-ci
Copy link

openshift-ci bot commented Dec 19, 2024

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@shahsahil264
Copy link
Author

/lifecycle frozen

@openshift-ci
Copy link

openshift-ci bot commented Dec 20, 2024

@shahsahil264: The lifecycle/frozen label cannot be applied to Pull Requests.

In response to this:

/lifecycle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chaitanyaenr
Copy link
Member

/reopen

@openshift-ci openshift-ci bot reopened this Jan 27, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jan 27, 2025

@chaitanyaenr: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chaitanyaenr
Copy link
Member

@rpattath @ahardin-rh PTAL when you get a chance. Thanks!

@ahardin-rh ahardin-rh added peer-review-needed Signifies that the peer review team needs to review this PR and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Jan 27, 2025
@ahardin-rh ahardin-rh added this to the Continuous Release milestone Jan 27, 2025
@shahsahil264
Copy link
Author

Thanks for all the suggestions @stevsmit !!

I have made the changes as suggested

@openshift-ci
Copy link

openshift-ci bot commented Feb 25, 2025

@shahsahil264: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@shahsahil264
Copy link
Author

@rpattath @paigerube14

Copy link
Member

@chaitanyaenr chaitanyaenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2025
@bergerhoffer
Copy link
Contributor

The branch/enterprise-4.20 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.19. And any PR going into main must also target the latest version branch (enterprise-4.20).

If the update in your PR does NOT apply to version 4.20 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 15, 2025
@chaitanyaenr
Copy link
Member

/remove-lifecycle stale.

@chaitanyaenr
Copy link
Member

@stevsmit need your review when you get a chance. Thanks!

@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 16, 2025
@bergerhoffer
Copy link
Contributor

The branch/enterprise-4.21 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.20. And any PR going into main must also target the latest version branch (enterprise-4.21).

If the update in your PR does NOT apply to version 4.21 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

@chaitanyaenr
Copy link
Member

Thanks for the feedback @bergerhoffer, appreciate it! @shahsahil264 let's target it PR againt enterprise 4.21 instead of main given that the content is applicable. Thoughts?

@chaitanyaenr
Copy link
Member

/remove-lifecycle rotten

@openshift-ci openshift-ci bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 20, 2025
@bergerhoffer
Copy link
Contributor

@chaitanyaenr You do not need to change this target away from main unless the update is only applicable to an older version. For example, if the update only applied to version 4.15, then you would target this only to enterprise-4.15.

But as long as this still applies to the newest version (4.21), then you can keep this PR targeting main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 branch/enterprise-4.21 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants