Skip to content

Conversation

@Maharshi-Project
Copy link

@Maharshi-Project Maharshi-Project commented Sep 20, 2024

Version(s): pipelines-docs-1.14, pipelines-docs-1.15, pipelines-docs-1.16

Issue: https://issues.redhat.com/browse/RHDEVDOCS-6146

Link to docs preview: https://82210--ocpdocs-pr.netlify.app/openshift-pipelines/latest/tkn_cli/op-tkn-reference.html

QE review:

  • QE has approved this change.

Additional information:
Updated the document according to RHDEVDOCS-6146

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 20, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 20, 2024

@Maharshi-Project: This pull request references RHDEVDOCS-6146 which is a valid jira issue.

In response to this:

Version(s): pipelines-docs-1.14, pipelines-docs-1.15, pipelines-docs-1.16

Issue: https://issues.redhat.com/browse/RHDEVDOCS-6146

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Updated the document according to RHDEVDOCS-6146

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 20, 2024
@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2024

Hi @Maharshi-Project. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 24, 2024
@Maharshi-Project
Copy link
Author

@eromanova97
Can you please review this PR ?

@openshift-ci
Copy link

openshift-ci bot commented Sep 24, 2024

@Maharshi-Project: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Srivaralakshmi
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 24, 2024
@Srivaralakshmi Srivaralakshmi added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. pipelines and removed ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Sep 24, 2024
@Srivaralakshmi Srivaralakshmi added this to the Continuous Release milestone Sep 24, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 24, 2024

🤖 Wed Sep 25 13:22:22 - Prow CI generated the docs preview:

https://82210--ocpdocs-pr.netlify.app/openshift-pipelines/latest/tkn_cli/op-tkn-reference.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 24, 2024

@Maharshi-Project: This pull request references RHDEVDOCS-6146 which is a valid jira issue.

In response to this:

Version(s): pipelines-docs-1.14, pipelines-docs-1.15, pipelines-docs-1.16

Issue: https://issues.redhat.com/browse/RHDEVDOCS-6146

Link to docs preview: https://82210--ocpdocs-pr.netlify.app/openshift-pipelines/latest/tkn_cli/op-tkn-reference.html

QE review:

  • QE has approved this change.

Additional information:
Updated the document according to RHDEVDOCS-6146

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eromanova97
Copy link
Contributor

/ok-to-test
/lgtm

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 25, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2024
@Srivaralakshmi
Copy link
Contributor

/lgtm

aireilly and others added 25 commits October 31, 2024 11:16
[OSDOCS-12502]:Create a separate link for the GCP supported regions for OSD
OSDOCS#12487: updating agent links
OCPBUGS-38689: Add section for xpn deletion permissions
TELCODOCS-1985: Day-2 upgrades for telco core clusters
OSDOCS#11934: Multiarch Tuning Operator release notes
[OSDOCS-12444]: Adding prereq and reference to disable HCP procedure
TELCODOCS-1853 Issue in file networking/metallb/metallb-operator-inst…
Removed redundant metadata field in example
OSDOCS#11934: Multiarch Tuning Operator release date update
OCPBUGS#34724: Removed incorrect vSphere link and replaced step
OSDOCS-11695 adding Nutanix FVN to docs
@Srivaralakshmi
Copy link
Contributor

Hello @Maharshi-Project: I see 9 commits now. There seems to be some issue with rebasing (syncing) with the pipelines-docs-main branch, which caused multiple commits and changes appearing in your PR.

It is difficult to help with this fix from distance, but I will try my best. You can try these steps to fix it:

$ git checkout <your_feature_branch> #(for example, git checkout feature-pipeline-docs-main)
$ git fetch upstream
$ git rebase upstream/pipelines-docs-main
$ git push -f origin <your_feature_branch> #(for example, git push -f origin feature-pipeline-docs-main)

If something goes wrong (you'll see some merge conflicts when you run the git rebase upstream/pipelines-docs-main command), then the easier option is to update your local repository and start your PR from scratch:

$ git checkout pipelines-docs-main
$ git fetch upstream
$ git rebase upstream/pipelines-docs-main
$ git push origin pipelines-docs-main
$ git checkout -b <new_feature_branch>

And make changes again on the new up-to-date feature branch 🙂 Thank you!

@Maharshi-Project Maharshi-Project closed this by deleting the head repository Nov 4, 2024
@openshift-ci
Copy link

openshift-ci bot commented Nov 4, 2024

@Maharshi-Project: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/validate-portal 6dc45bc link true /test validate-portal
ci/prow/validate-asciidoc 6dc45bc link true /test validate-asciidoc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. peer-review-done Signifies that the peer review team has reviewed this PR pipelines size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.