Skip to content

OSDOCS#13131: Updated hosted control planes with its attributes #87138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2025
Merged

OSDOCS#13131: Updated hosted control planes with its attributes #87138

merged 1 commit into from
Jan 17, 2025

Conversation

@xenolinux
Copy link
Contributor

@xenolinux xenolinux commented Jan 16, 2025 •
edited
Loading

Replace "hosted control planes" with its attributes: {hcp} and {hcp-capital}

Version(s): 4.17+

Issue: https://issues.redhat.com/browse/OSDOCS-13131

Link to docs preview:

QE review:

  • Not Applicable

Additional information:

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 16, 2025
@xenolinux xenolinux changed the title Updated with its attributes Updated hosted control planes with its attributes Jan 16, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 16, 2025 •
edited
Loading

🤖 Fri Jan 17 14:32:22 - Prow CI generated the docs preview:
https://87138--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@xenolinux xenolinux changed the title Updated hosted control planes with its attributes OSDOCS#13131: Updated hosted control planes with its attributes Jan 16, 2025
@xenolinux xenolinux added this to the Continuous Release milestone Jan 16, 2025
@xenolinux xenolinux force-pushed the use-hcp-attr branch 3 times, most recently from 2e4d2ab to 8d1ae64 Compare January 17, 2025 10:06
@xenolinux xenolinux added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 17, 2025
@ShaunaDiaz ShaunaDiaz added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 17, 2025
ShaunaDiaz
ShaunaDiaz reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@ShaunaDiaz ShaunaDiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks like it is rendering OK. Just a couple comments on removal of a "the" that is inconsistent with the rest of the module there.

modules/hcp-enable-manual-addon.adoc Outdated
Replace `filename` with the name of the file that you created.

. Confirm that the `hypershift-addon` is installed by running the following command:
. Confirm that `hypershift-addon` is installed by running the following command:
Copy link
Contributor

@ShaunaDiaz ShaunaDiaz Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
. Confirm that `hypershift-addon` is installed by running the following command:
. Confirm that the `hypershift-addon` managed cluster add-on is installed by running the following command:

The "the" was missing the object.

Copy link
Contributor Author

@xenolinux xenolinux Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

modules/hcp-enable-manual-addon.adoc Outdated
----

Your HyperShift add-on is installed and the hosting cluster is available to create and manage hosted clusters.
Your `hypershift-addon` is installed and the hosting cluster is available to create and manage hosted clusters.
Copy link
Contributor

@ShaunaDiaz ShaunaDiaz Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Your `hypershift-addon` is installed and the hosting cluster is available to create and manage hosted clusters.
Your `hypershift-addon` managed cluster add-on is installed and the hosting cluster is available to create and manage hosted clusters.

Copy link
Contributor Author

@xenolinux xenolinux Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@ShaunaDiaz ShaunaDiaz added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jan 17, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jan 17, 2025

@xenolinux: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@xenolinux xenolinux merged commit 51cdac6 into openshift:main Jan 17, 2025
2 checks passed
@xenolinux xenolinux deleted the use-hcp-attr branch January 17, 2025 15:06
@xenolinux
Copy link
Contributor Author

xenolinux commented Jan 17, 2025

/cherrypick enterprise-4.18

@xenolinux
Copy link
Contributor Author

xenolinux commented Jan 17, 2025

/cherrypick enterprise-4.17

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 17, 2025

@xenolinux: new pull request created: #87206

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 17, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 17, 2025

@xenolinux: new pull request created: #87207

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShaunaDiaz ShaunaDiaz ShaunaDiaz left review comments

+1 more reviewer

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.17 branch/enterprise-4.18 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

5 participants

@xenolinux @ocpdocs-previewbot @openshift-cherrypick-robot @ShaunaDiaz @ocpdocs-vale-bot