Skip to content

Conversation

@agantony
Copy link
Contributor

@agantony agantony commented Jan 17, 2025

Version(s):
4.6

Issue:
https://issues.redhat.com/browse/ROX-27715

Source:
https://issues.redhat.com/projects/ROX/versions/12439468

Link to docs preview:
https://87186--ocpdocs-pr.netlify.app/openshift-acs/latest/release_notes/46-release-notes#about-release-462_release-notes-46

SME review:

  • SME has approved this change.

Additional information:

  • Merge into rhacs-docs-4.6
  • No cherry-pick needed

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 17, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 17, 2025

@agantony: This pull request references ROX-27715 which is a valid jira issue.

In response to this:

Version(s):
4.6

Issue:
https://issues.redhat.com/browse/ROX-27715

Link to docs preview:

SME review:

  • SME has approved this change.

Additional information:

  • Merge into rhacs-docs-4.6
  • No cherry-pick needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@agantony agantony added this to the Continuous Release milestone Jan 17, 2025
@agantony agantony added the RHACS Label for RHACS related PRs that go in the rhacs-docs branch label Jan 17, 2025
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 17, 2025
@agantony agantony added rhacs-docs-4.6 peer-review-needed Signifies that the peer review team needs to review this PR and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 17, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 17, 2025

@agantony: This pull request references ROX-27715 which is a valid jira issue.

In response to this:

Version(s):
4.6

Issue:
https://issues.redhat.com/browse/ROX-27715

Source:
https://issues.redhat.com/projects/ROX/versions/12439468

Link to docs preview:

SME review:

  • SME has approved this change.

Additional information:

  • Merge into rhacs-docs-4.6
  • No cherry-pick needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 17, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 17, 2025

🤖 Tue Feb 04 13:10:11 - Prow CI generated the docs preview:
https://87186--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 17, 2025

@agantony: This pull request references ROX-27715 which is a valid jira issue.

In response to this:

Version(s):
4.6

Issue:
https://issues.redhat.com/browse/ROX-27715

Source:
https://issues.redhat.com/projects/ROX/versions/12439468

Link to docs preview:
https://87186--ocpdocs-pr.netlify.app/openshift-acs/latest/release_notes/46-release-notes#about-release-462_release-notes-46

SME review:

  • SME has approved this change.

Additional information:

  • Merge into rhacs-docs-4.6
  • No cherry-pick needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@xenolinux xenolinux added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 17, 2025
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments; otherwise LGTM

@xenolinux xenolinux added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jan 17, 2025
@agantony agantony force-pushed the ROX27715-rhacs-docs-4.6 branch from 370de90 to 052f517 Compare January 20, 2025 07:02
@kurlov
Copy link
Member

kurlov commented Jan 20, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 20, 2025

@agantony: This pull request references ROX-27715 which is a valid jira issue.

In response to this:

Version(s):
4.6

Issue:
https://issues.redhat.com/browse/ROX-27715

Source:
https://issues.redhat.com/projects/ROX/versions/12439468

Link to docs preview:
https://87186--ocpdocs-pr.netlify.app/openshift-acs/latest/release_notes/46-release-notes#about-release-462_release-notes-46

SME review:

  • SME has approved this change.

Additional information:

  • Merge into rhacs-docs-4.6
  • No cherry-pick needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@agantony agantony force-pushed the ROX27715-rhacs-docs-4.6 branch from 052f517 to 6e45cc1 Compare January 23, 2025 08:26
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jan 23, 2025

New changes are detected. LGTM label has been removed.

@agantony agantony force-pushed the ROX27715-rhacs-docs-4.6 branch from 6e45cc1 to f871d97 Compare January 23, 2025 08:26
@agantony agantony force-pushed the ROX27715-rhacs-docs-4.6 branch 2 times, most recently from ac7bf62 to 06b8b93 Compare February 4, 2025 12:51
ROX27715 Review comments

ROX27715 Updating GA date

ROX27715 Updating date

ROX27715 Updating release date
@agantony agantony force-pushed the ROX27715-rhacs-docs-4.6 branch from 06b8b93 to 5285a9f Compare February 4, 2025 12:52
@openshift-ci
Copy link

openshift-ci bot commented Feb 4, 2025

@agantony: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@agantony agantony merged commit d575a72 into openshift:rhacs-docs-4.6 Feb 4, 2025
2 checks passed
@agantony agantony added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.6 size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants