OCPBUGS-43683: Clarify MTU configuration in SR-IOV network node policy

[amolnar-gh]

Version(s): 4.14, 4.15, 4.16, 4.17, 4.18

Issue: https://issues.redhat.com/browse/OCPBUGS-43683

Link to docs preview:
https://87188--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/hardware_networks/configuring-sriov-device.html#nw-sriov-networknodepolicy-object_configuring-sriov-device

QE review:

• QE has approved this change.

Additional information:

[openshift-ci-robot]

@amolnar-rh: This pull request references Jira Issue OCPBUGS-43683, which is invalid:

• expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s): 4.14, 4.15, 4.16, 4.17, 4.18

Issue: https://issues.redhat.com/browse/OCPBUGS-43683

Link to docs preview:

QE review:

• QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ocpdocs-previewbot]

🤖 Tue Jan 21 13:41:40 - Prow CI generated the docs preview:

https://87188--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/hardware_networks/configuring-sriov-device.html

[cgoncalves]

LGTM with @zeeke's comments.

[openshift-ci]

@amolnar-rh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[zeeke]

/lgtm

Thanks for having addressed my comments!

[evgenLevin]

/lgtm

[amolnar-gh]

/label peer-review-needed

[xenolinux]

LGTM

General comment: To avoid openshift bots checking the state of Jira issues upon each update and printing unnecessary warnings, use # in the PR title instead of dash -- for example, OCPBUGS#12345: Fix the title

[amolnar-gh]

/label merge-review-needed

[openshift-ci-robot]

@amolnar-rh: Jira Issue OCPBUGS-43683 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

In response to this:

Version(s): 4.14, 4.15, 4.16, 4.17, 4.18

Issue: https://issues.redhat.com/browse/OCPBUGS-43683

Link to docs preview:
https://87188--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/hardware_networks/configuring-sriov-device.html#nw-sriov-networknodepolicy-object_configuring-sriov-device

QE review:

• QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[xenolinux]

/cherrypick enterprise-4.14

[xenolinux]

/cherrypick enterprise-4.15

[xenolinux]

/cherrypick enterprise-4.16

[xenolinux]

/cherrypick enterprise-4.17

[xenolinux]

/cherrypick enterprise-4.18

[openshift-cherrypick-robot]

@xenolinux: #87188 failed to apply on top of branch "enterprise-4.14":

Applying: OCPBUGS-43683: Clarify MTU configuration in SR-IOV network node policy
Using index info to reconstruct a base tree...
M	modules/nw-sriov-networknodepolicy-object.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/nw-sriov-networknodepolicy-object.adoc
CONFLICT (content): Merge conflict in modules/nw-sriov-networknodepolicy-object.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-43683: Clarify MTU configuration in SR-IOV network node policy

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@xenolinux: #87188 failed to apply on top of branch "enterprise-4.15":

Applying: OCPBUGS-43683: Clarify MTU configuration in SR-IOV network node policy
Using index info to reconstruct a base tree...
M	modules/nw-sriov-networknodepolicy-object.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/nw-sriov-networknodepolicy-object.adoc
CONFLICT (content): Merge conflict in modules/nw-sriov-networknodepolicy-object.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-43683: Clarify MTU configuration in SR-IOV network node policy

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@xenolinux: #87188 failed to apply on top of branch "enterprise-4.16":

Applying: OCPBUGS-43683: Clarify MTU configuration in SR-IOV network node policy
Using index info to reconstruct a base tree...
M	modules/nw-sriov-networknodepolicy-object.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/nw-sriov-networknodepolicy-object.adoc
CONFLICT (content): Merge conflict in modules/nw-sriov-networknodepolicy-object.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-43683: Clarify MTU configuration in SR-IOV network node policy

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@xenolinux: #87188 failed to apply on top of branch "enterprise-4.17":

Patch is empty.
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To record the empty patch as an empty commit, run "git am --allow-empty".
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@xenolinux: #87188 failed to apply on top of branch "enterprise-4.18":

Applying: OCPBUGS-43683: Clarify MTU configuration in SR-IOV network node policy
Using index info to reconstruct a base tree...
M	modules/nw-sriov-networknodepolicy-object.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/nw-sriov-networknodepolicy-object.adoc
CONFLICT (content): Merge conflict in modules/nw-sriov-networknodepolicy-object.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-43683: Clarify MTU configuration in SR-IOV network node policy

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[xenolinux]

/cherrypick enterprise-4.17

[openshift-cherrypick-robot]

@xenolinux: #87188 failed to apply on top of branch "enterprise-4.17":

Applying: OCPBUGS-43683: Clarify MTU configuration in SR-IOV network node policy
Using index info to reconstruct a base tree...
M	modules/nw-sriov-networknodepolicy-object.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/nw-sriov-networknodepolicy-object.adoc
CONFLICT (content): Merge conflict in modules/nw-sriov-networknodepolicy-object.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-43683: Clarify MTU configuration in SR-IOV network node policy

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[xenolinux]

@amolnar-rh Sadly all of the automated CPs failed due to merge conflicts. Can you please create manual CPs?

[xenolinux]

Trying to CP one more time to test

[xenolinux]

/cherrypick enterprise-4.18

[openshift-cherrypick-robot]

@xenolinux: #87188 failed to apply on top of branch "enterprise-4.18":

Applying: OCPBUGS-43683: Clarify MTU configuration in SR-IOV network node policy
Using index info to reconstruct a base tree...
M	modules/nw-sriov-networknodepolicy-object.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/nw-sriov-networknodepolicy-object.adoc
CONFLICT (content): Merge conflict in modules/nw-sriov-networknodepolicy-object.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-43683: Clarify MTU configuration in SR-IOV network node policy

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[xenolinux]

Strangely, this IMP note was not present in 4.14-4.18 but it was there in main (!!!), hence the conflicts.