Skip to content

HCP minor nits #87208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2025
Merged

HCP minor nits #87208

merged 1 commit into from
Jan 17, 2025

Conversation

@xenolinux
Copy link
Contributor

@xenolinux xenolinux commented Jan 17, 2025 •
edited
Loading

Version(s): 4.17+

Issue: No jira

Link to docs preview: https://87208--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hosted_control_planes/hcp-import.html#hcp-import-manual-aws_hcp-import

QE review:

  • Not required.

Additional information:

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 17, 2025
@xenolinux xenolinux added this to the Continuous Release milestone Jan 17, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 17, 2025

🤖 Fri Jan 17 15:34:04 - Prow CI generated the docs preview:

https://87208--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hosted_control_planes/hcp-import.html

@openshift-ci
Copy link

openshift-ci bot commented Jan 17, 2025

@xenolinux: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@xenolinux xenolinux added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 17, 2025
@lpettyjo lpettyjo added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 17, 2025
@lpettyjo lpettyjo self-requested a review January 17, 2025 15:50
lpettyjo
lpettyjo reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@lpettyjo lpettyjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lpettyjo lpettyjo added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jan 17, 2025
@xenolinux xenolinux merged commit bb4acf8 into openshift:main Jan 17, 2025
2 checks passed
@xenolinux xenolinux deleted the minor-nits branch January 17, 2025 16:14
@xenolinux
Copy link
Contributor Author

xenolinux commented Jan 17, 2025

/cherrypick enterprise-4.18

@xenolinux
Copy link
Contributor Author

xenolinux commented Jan 17, 2025

/cherrypick enterprise-4.17

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 17, 2025

@xenolinux: new pull request created: #87219

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 17, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 17, 2025

@xenolinux: new pull request created: #87220

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpettyjo lpettyjo lpettyjo left review comments

Assignees

No one assigned

Labels

branch/enterprise-4.17 branch/enterprise-4.18 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

4 participants

@xenolinux @ocpdocs-previewbot @openshift-cherrypick-robot @lpettyjo