-
Couldn't load subscription status.
- Fork 1.8k
OSDOCS-New-add-machine-pool-Win-LI to ROSA HCP docs. #87634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
1ad928d to
005fba0
Compare
005fba0 to
5694f45
Compare
f6754f0 to
db8df98
Compare
db8df98 to
1fe8c6f
Compare
|
@andreadecorte Can you please review this when you get a chance? Many thanks. |
|
/label peer-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
1fe8c6f to
6f61720
Compare
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
/remove-lifecycle stale |
6f61720 to
612c1c1
Compare
|
@AedinC actually the commands here are still based the instructions for the public preview, the GA will have a few changes in the UX, so we can review when we start approaching to the production release. Overall I don't expect major changes in any case, thanks! |
|
/hold |
Thanks @andreadecorte. I will be on leave from July 7th to August 5th but will have time to implement the changes before feature release when I come back. |
b513f47 to
a0566ae
Compare
a0566ae to
a0bc2b5
Compare
534629b to
d1646f8
Compare
|
Hi @andreadecorte I revised the docs based on GA feature design. Can you please advise if any thing needs to be changed or added? Thanks. |
|
hi Aedin, I think changes look good, thanks! I also ask @BraeTroutman to take a look, he is now leading the feature so you can coordinate with him for the target release |
90a105d to
93f3121
Compare
93f3121 to
347f1bd
Compare
|
@AedinC: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@AkashKanni Can you please review this PR? Many thanks. |
Version(s):
4.19+
Issue:
https://issues.redhat.com/browse/OSDOCS-12593
Link to docs preview:
Creating a machine pool using OpenShift Cluster Manager
Creating a machine pool using the ROSA CLI
What' s new
Peer review:
SME review:
QE review:
Additional information: