Skip to content

Conversation

@smiglani-r
Copy link

In below documentation:
https://docs.openshift.com/container-platform/4.18/hardware_enablement/kmm-kernel-module-management.html the command provided for adding SCC to a serviceaccount while deploying KMM in custom namespace is incorrect.

$ oc adm policy add-scc-to-user privileged -z "${serviceAccountName}" [ -n "${namespace}" ]

Above command is giving an error because of incorrect brackets, ideally it should be:

Right Command:
"$ oc adm policy add-scc-to-user privileged -z serviceAccountName -n namespace" We can add note below the right command: Replace the 'namespace' argument with the 'operator namespace'.

Version(s):
OCP 4.18

Issue:
https://issues.redhat.com/browse/OCPBUGS-52586

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

In below documentation:
https://docs.openshift.com/container-platform/4.18/hardware_enablement/kmm-kernel-module-management.html the command provided for adding SCC to a serviceaccount while deploying KMM in custom namespace is incorrect.

$ oc adm policy add-scc-to-user privileged -z "${serviceAccountName}" [ -n "${namespace}" ]

Above command is giving an error because of incorrect brackets, ideally it should be:

Right Command:
"$ oc adm policy add-scc-to-user privileged -z serviceAccountName -n namespace"
We can add note below the right command: Replace the 'namespace' argument with the 'operator namespace'.
@smiglani-r
Copy link
Author

/label peer-review-needed

@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. peer-review-needed Signifies that the peer review team needs to review this PR needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 11, 2025
@openshift-ci
Copy link

openshift-ci bot commented Mar 11, 2025

Hi @smiglani-r. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@opayne1 opayne1 added peer-review-in-progress Signifies that the peer review team is reviewing this PR branch/enterprise-4.18 and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 11, 2025
@opayne1 opayne1 added this to the Continuous Release milestone Mar 11, 2025
@opayne1 opayne1 added branch/enterprise-4.19 and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 11, 2025
Copy link
Contributor

@opayne1 opayne1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why prow didn't give a preview, I removed the needs-ok-to-test label because I thought that might fix. But everything looks good to me pending a preview link and approval from qe.

@opayne1 opayne1 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 11, 2025
@opayne1
Copy link
Contributor

opayne1 commented Mar 11, 2025

I don't know why prow didn't give a preview, I removed the needs-ok-to-test label because I thought that might fix. But everything looks good to me pending a preview link and approval from qe.

I think it might have something to do with the merge freeze today. Disregard.

@kalexand-rh
Copy link
Contributor

/retest

@ocpdocs-previewbot
Copy link

@openshift-ci
Copy link

openshift-ci bot commented Apr 10, 2025

@smiglani-r: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bergerhoffer
Copy link
Contributor

The branch/enterprise-4.20 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.19. And any PR going into main must also target the latest version branch (enterprise-4.20).

If the update in your PR does NOT apply to version 4.20 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 15, 2025
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 15, 2025
@bergerhoffer
Copy link
Contributor

The branch/enterprise-4.21 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.20. And any PR going into main must also target the latest version branch (enterprise-4.21).

If the update in your PR does NOT apply to version 4.21 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 branch/enterprise-4.21 lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants