Skip to content

HCIDOCS-651-followup: Oracle Cloud C3 finalizing #91884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

HCIDOCS-651-followup: Oracle Cloud C3 finalizing #91884

wants to merge 8 commits into from

Conversation

@tshwartz
Copy link
Contributor

@tshwartz tshwartz commented Apr 8, 2025 •
edited
Loading

Applying peer comments from Sebastian in this merged MR:
#88897

QE review approved on original and not needed here.

Version(s):
4.18, 4.19, main

Issue:
https://issues.redhat.com/browse/HCIDOCS-651

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 8, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 8, 2025 •
edited
Loading

🤖 Sun Apr 20 10:48:13 - Prow CI generated the docs preview:

https://91884--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_oci/installing-c3-assisted-installer.html

@tshwartz tshwartz force-pushed the HCIDOCS-651-followup branch from 942b6e7 to b51b682 Compare April 9, 2025 08:12
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 9, 2025
@tshwartz tshwartz force-pushed the HCIDOCS-651-followup branch from c2b887e to 7654316 Compare April 9, 2025 10:56
@tshwartz
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 15, 2025
@skopacz1 skopacz1 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Apr 15, 2025
skopacz1
skopacz1 reviewed Apr 15, 2025
View reviewed changes
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, otherwise LGTM. I think that adding these prereqs will make QE review necessary, even if most of them just describe the actions that users would have taken in prior sections

modules/c3-assisted-installer-completing-installation-manifests.adoc
* Prepare the custom manifests. For details, see step 8 in the "Install the Cluster using the RH Assisted Installer UI" section of the link:https://www.oracle.com/a/otn/docs/compute_cloud_at_customer_assisted_installer.pdf?source=:em:nl:mt::::PCATP[Oracle documentation].
* You have prepared the custom manifests. For details, see step 8 in the "Install the Cluster using the RH Assisted Installer UI" section of the link:https://www.oracle.com/a/otn/docs/compute_cloud_at_customer_assisted_installer.pdf?source=:em:nl:mt::::PCATP[Oracle documentation].
* You have added NTP sources to failed hosts on the *Networking* page of the {ai-full} wizard.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comment but just a heads up that this prereq alone is changing technical accuracy and would make at least a QE review of the PR necessary.

@skopacz1 skopacz1 added peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.18 branch/enterprise-4.19 and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 15, 2025
@skopacz1 skopacz1 added this to the Continuous Release milestone Apr 15, 2025
@tshwartz tshwartz force-pushed the HCIDOCS-651-followup branch 6 times, most recently from 131944b to 7ee1393 Compare April 18, 2025 04:55
@tshwartz tshwartz force-pushed the HCIDOCS-651-followup branch from 7ee1393 to 8508586 Compare April 20, 2025 10:41
@openshift-ci
Copy link

openshift-ci bot commented Apr 20, 2025

@tshwartz: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tshwartz
Copy link
Contributor Author

rebuild

@bergerhoffer
Copy link
Contributor

The branch/enterprise-4.20 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.19. And any PR going into main must also target the latest version branch (enterprise-4.20).

If the update in your PR does NOT apply to version 4.20 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 15, 2025
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 16, 2025
@bergerhoffer
Copy link
Contributor

The branch/enterprise-4.21 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.20. And any PR going into main must also target the latest version branch (enterprise-4.21).

If the update in your PR does NOT apply to version 4.21 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skopacz1 skopacz1 skopacz1 left review comments

Assignees

No one assigned

Labels

branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 branch/enterprise-4.21 lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

5 participants

@tshwartz @ocpdocs-previewbot @bergerhoffer @openshift-bot @skopacz1