Skip to content

Conversation

@amandverma
Copy link

@amandverma amandverma commented May 26, 2025

Updated line 48 to 51, as inputRefs and filterRefs are accepting array type of value.

clf.spec.pipeline.inputRefs|outputRefs|filterRefs should of array type instead of string.

Version(s):

4.14 - 4.18

Issue:

https://issues.redhat.com/browse/OBSDOCS-970

Link to docs preview:

https://93743--ocpdocs-pr.netlify.app/
https://93743--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/logging-6.1/log6x-clf-6.1.html
https://93743--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/logging-6.2/log6x-clf-6.2.html

QE review:

  • QE has approved this change.

Additional information:

Updated line 48 to 51, as inputRefs and filterRefs are accepting array type of value.
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 26, 2025
@openshift-ci
Copy link

openshift-ci bot commented May 26, 2025

@amandverma: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@amandverma
Copy link
Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 26, 2025
Copy link
Contributor

@mletalie mletalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 27, 2025
Copy link
Contributor

@mletalie mletalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label peer-review-done
/remove-label peer-review-needed
/remove-label peer-review-in-progress
/lgtm

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels May 27, 2025
@mletalie
Copy link
Contributor

Hello @amandverma,
Overall, looks good to me, but from what I can tell, your changes don't reflect the exact ask in the ticket, from what I can tell. I may be interpreting this incorrectly, but wanted to mention. Thanks.
image

@openshift-ci openshift-ci bot removed the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 27, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2025
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 26, 2025
@amandverma
Copy link
Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 9, 2025
@jab-rh
Copy link
Contributor

jab-rh commented Sep 15, 2025

@amandverma, does this not go into 4.20? If so, it cannot go into main either.

@lahinson lahinson added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 and removed merge-review-needed Signifies that the merge review team needs to review this PR lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 15, 2025
@lahinson lahinson added this to the Continuous Release milestone Sep 15, 2025
@lahinson lahinson removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Sep 15, 2025
@lahinson
Copy link
Contributor

Hi @amandverma - Be sure to note whether QE has approved this PR before you add it to the merge review queue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants