Skip to content

Conversation

@dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Aug 8, 2025

CM sent on the 8 Aug.

Version(s):
4.16

Issue:
OSDOCS-15290

Link to docs preview:

  • SME has approved this change (Marcelo Guerrero Viveros).
  • QE has approved this change (Weibin Liang).

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 8, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 8, 2025

@dfitzmau: This pull request references OSDOCS-15290 which is a valid jira issue.

In response to this:

Version(s):
4.16

Issue:
OSDOCS-15290

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 8, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Aug 8, 2025

🤖 Mon Aug 11 16:15:36 - Prow CI generated the docs preview:

https://97343--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-16-release-notes.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 8, 2025

@dfitzmau: This pull request references OSDOCS-15290 which is a valid jira issue.

In response to this:

Version(s):
4.16

Issue:
OSDOCS-15290

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 8, 2025

@dfitzmau: This pull request references OSDOCS-15290 which is a valid jira issue.

In response to this:

Version(s):
4.16

Issue:
OSDOCS-15290

Link to docs preview:

  • SME has approved this change (Marcelo Guerrero Viveros).
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mlguerrero12
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 8, 2025

@dfitzmau: This pull request references OSDOCS-15290 which is a valid jira issue.

In response to this:

Version(s):
4.16

Issue:
OSDOCS-15290

Link to docs preview:

  • SME has approved this change (Marcelo Guerrero Viveros).
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 8, 2025

@dfitzmau: This pull request references OSDOCS-15290 which is a valid jira issue.

In response to this:

Version(s):
4.16

Issue:
OSDOCS-15290

Link to docs preview:

  • SME has approved this change (Marcelo Guerrero Viveros).
  • QE has approved this change (Weibin Liang).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@weliang1
Copy link

weliang1 commented Aug 8, 2025

/lgtm

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 8, 2025

@dfitzmau: This pull request references OSDOCS-15290 which is a valid jira issue.

In response to this:

Version(s):
4.16

Issue:
OSDOCS-15290

Link to docs preview:

  • SME has approved this change (Marcelo Guerrero Viveros).
  • QE has approved this change (Weibin Liang).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 8, 2025

@dfitzmau: This pull request references OSDOCS-15290 which is a valid jira issue.

In response to this:

CM sent on the 8 Aug.

Version(s):
4.16

Issue:
OSDOCS-15290

Link to docs preview:

  • SME has approved this change (Marcelo Guerrero Viveros).
  • QE has approved this change (Weibin Liang).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfitzmau dfitzmau added the merge-review-needed Signifies that the merge review team needs to review this PR label Aug 11, 2025
@jeana-redhat jeana-redhat added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Aug 11, 2025
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One heading metadata issue and just a convention I noticed while here. Otherwise LGTM 👍

/remove-label merge-review-in-progress
/remove-label merge-review-needed

[id="ocp-4-16-networking_{context}"]
=== Networking

[id="ocp-4-16-ipv6-default-ipvlan"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing _{context} on ID here

@jeana-redhat jeana-redhat added this to the Continuous Release milestone Aug 11, 2025
@openshift-ci openshift-ci bot removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Aug 11, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2025
@openshift-ci
Copy link

openshift-ci bot commented Aug 11, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link

openshift-ci bot commented Aug 11, 2025

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dfitzmau dfitzmau merged commit 2d625d9 into openshift:enterprise-4.16 Aug 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.16 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants