Skip to content

CNV#23697: ARM support #97406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2025
Merged

CNV#23697: ARM support #97406

merged 1 commit into from
Oct 27, 2025
+26 −5

Conversation

@ousleyp
Copy link
Member

@ousleyp ousleyp commented Aug 11, 2025 •
edited
Loading

@ousleyp ousleyp added this to the Continuous Release milestone Aug 11, 2025
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 11, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Aug 11, 2025 •
edited
Loading

🤖 Mon Oct 27 14:27:27 - Prow CI generated the docs preview:

https://97406--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/install/preparing-cluster-for-virt.html
https://97406--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/vm_networking/virt-connecting-vm-to-linux-bridge.html
https://97406--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/virt/install/preparing-cluster-for-virt.html
https://97406--ocpdocs-pr.netlify.app/openshift-rosa/latest/virt/install/preparing-cluster-for-virt.html

ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Aug 11, 2025
View reviewed changes
dominikholler
dominikholler reviewed Aug 12, 2025
View reviewed changes
virt/install/preparing-cluster-for-virt.adoc Outdated
====
* Support for AMD and Intel 64-bit architectures (x86-64-v2).
* Support for AMD, Intel 64-bit (x86-64-v2), and ARM64-based (`arm64` or `aarch64`) architectures.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • s390x is supported, too
  • The following items are only for x86-64 relevant, but I have no idea if there are similar requirements for the other architectures:
    • Support for AMD and Intel 64-bit architectures (x86-64-v2).
    • Support for Intel 64 or AMD64 CPU extensions.
    • Intel VT or AMD-V hardware virtualization extensions enabled.
    • NX (no execute) flag enabled.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for s390x , the difference / requirements are mentioned here : https://docs.redhat.com/en/documentation/openshift_container_platform/4.19/html/virtualization/installing#ibm-z-linuxone-compatibility_preparing-cluster-for-virt
i would suggest in this section to point to the link above , or since we are talking here only about cpu requirements then i suggest to add/repeat only this following line from the section above (in the link ). :
"When configuring the default CPU model, the spec.defaultCPUModel value is "gen15b" for an IBM Z cluster."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dominikholler @nbziouec I slightly reworked this list; can you please look at the latest commit and let me know if there are inaccuracies? Thanks! 4e3ba3b

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me @ousleyp thanks !

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 12, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 12, 2025
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 12, 2025
@ousleyp
Copy link
Member Author

ousleyp commented Aug 12, 2025

/test validate-asciidoc

@ousleyp ousleyp requested review from dominikholler, kbidarkar and nbziouec and removed request for nbziouec August 12, 2025 19:47
@dominikholler
Copy link

looks great, thanks @ousleyp ! The doc contains all information I am currently aware of.

phoracek
phoracek approved these changes Aug 15, 2025
View reviewed changes
Copy link
Member

@phoracek phoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ousleyp ousleyp removed the request for review from dominikholler August 15, 2025 14:35
sjhala-ccs
sjhala-ccs reviewed Aug 15, 2025
View reviewed changes
Copy link
Contributor

@sjhala-ccs sjhala-ccs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bergerhoffer
Copy link
Contributor

The branch/enterprise-4.21 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.20. And any PR going into main must also target the latest version branch (enterprise-4.21).

If the update in your PR does NOT apply to version 4.21 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2025

@ousleyp: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kbidarkar
Copy link

LGTM

@ousleyp ousleyp merged commit 199ba5b into openshift:main Oct 27, 2025
2 checks passed
@ousleyp
Copy link
Member Author

ousleyp commented Oct 27, 2025

/cherrypick enterprise-4.20

@ousleyp
Copy link
Member Author

ousleyp commented Oct 27, 2025

/cherrypick enterprise-4.21

@openshift-cherrypick-robot
Copy link

@ousleyp: new pull request created: #101112

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 27, 2025
Merged
@openshift-cherrypick-robot
Copy link

@ousleyp: new pull request created: #101113

In response to this:

/cherrypick enterprise-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjhala-ccs sjhala-ccs sjhala-ccs left review comments

@kmajcher-rh kmajcher-rh Awaiting requested review from kmajcher-rh

@kbidarkar kbidarkar Awaiting requested review from kbidarkar

+4 more reviewers

@dominikholler dominikholler dominikholler left review comments

@nbziouec nbziouec nbziouec left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

@phoracek phoracek phoracek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.20 branch/enterprise-4.21 CNV Label for all CNV PRs size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.